Forum: IronRuby Workitem #6244 - request for code review

B3068fb9bae93b2889ffc73feb1b3195?d=identicon&s=25 Enrico Sada (Guest)
on 2011-08-01 15:34
(Received via mailing list)
Hi, i fixed workitem #6244 (
https://github.com/enricosada/IronLanguages/commit...),
i added '%N' option to time.strftime.

I added also the test to strftime mspec. I dont think i need to change
ironruby-tags-19, because the new test should pass now.

This is my first commit to ironruby, wiki say i need to ask to ml for
code
review before pull request. There is other i need to do?
959b1c9d700abfc065f5f40bf5a966a2?d=identicon&s=25 James Schementi (jschementi)
on 2011-08-01 17:01
(Received via mailing list)
Thanks! Looks good. Submit a pull request and I'll merge it in.

You can submit a pull request along with sending it to the mailing list
for code review; it's a good way to keep track of open reviews.

~js
959b1c9d700abfc065f5f40bf5a966a2?d=identicon&s=25 James Schementi (jschementi)
on 2011-08-01 17:36
(Received via mailing list)
On a related note, we should come up with a better way to keep our copy
of RubySpec in sync with the "truth":
https://github.com/rubyspec/rubyspec/. Volunteers welcome.
This topic is locked and can not be replied to.