Forum: IronRuby [patch] agdlr: Fix for Package.NormalizePath

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
740c85b27e1a80c5f908d81dca5d4fbf?d=identicon&s=25 Jb Evain (Guest)
on 2009-04-01 17:01
(Received via mailing list)
Attachment: Package.patch (701 Bytes)
Hey,

This patch is part of a bunch I sent to Jimmy privately. But they
haven't been applied, so am resending them here for review.

Package.NormalizePath transforms paths in the xap that use \ as a
directory separator to /. So use \ directly, instead of expecting it
to be the system directory separator.

Thanks,
E1deaac6561498a0e7472e6268ea9ccc?d=identicon&s=25 Jimmy Schementi (Guest)
on 2009-04-01 19:38
(Received via mailing list)
They are applied in the dev/mono branch, and I can apply them for 0.5.1.

~Jimmy
Sent from my phone
740c85b27e1a80c5f908d81dca5d4fbf?d=identicon&s=25 Jb Evain (Guest)
on 2009-04-01 20:04
(Received via mailing list)
Hey Jimmy,

On 4/1/09, Jimmy Schementi <Jimmy.Schementi@microsoft.com> wrote:
> They are applied in the dev/mono branch, and I can apply them for 0.5.1.

Yeah, that would be cool. Is there any reason for not merging them in
origin?
E1deaac6561498a0e7472e6268ea9ccc?d=identicon&s=25 Jimmy Schementi (Guest)
on 2009-04-01 20:14
(Received via mailing list)
No major reason ... they are small enough to be considered bug reports,
so I have no problem making the fixes. FYI, I have to be more careful
with substantial  improvements/features, for the same reason that
IronRuby.dll or the DLR can't accept contributions, but I hope to have a
clearer message on contributions in the future.

I don't have moonlight on any of my machines to test it out (though I
trust you =P). Can you point me at instructions for setting up
Moonlight? I have a Ubuntu VM , or is there another distro I should use
since you're testing more on it (SUSE I assume?).

~js
740c85b27e1a80c5f908d81dca5d4fbf?d=identicon&s=25 Jb Evain (Guest)
on 2009-04-01 21:06
(Received via mailing list)
On 4/1/09, Jimmy Schementi <Jimmy.Schementi@microsoft.com> wrote:
> No major reason ... they are small enough to be considered bug reports, so I have no 
problem making the fixes. FYI, I have to be more careful with substantial 
improvements/features, for the same reason that IronRuby.dll or the DLR can't accept 
contributions, but I hope to have a clearer message on contributions in the future.

Cool. I don't particularly care that my own personal patch is applied,
I care about having the feature working. So if you guys prefer bug
reports I can submit bugs reports.

>  I don't have moonlight on any of my machines to test it out (though I trust you =P). 
Can you point me at instructions for setting up Moonlight? I have a Ubuntu VM , or is 
there another distro I should use since you're testing more on it (SUSE I assume?).

I use openSUSE, but there's no reason you couldn't make it work
Ubuntu. You would have to setup Mono from svn, I suggest using:

http://www.mono-project.com/Parallel_Mono_Environments

There's some instructions for Moonlight here:

http://www.mono-project.com/Moonlight#Developing_Moonlight

But it's not always up to date as we are currently changing things a
lot. Don't hesitate to ask on moonlight-list  for help, or contact me
directly.

http://lists.ximian.com/mailman/listinfo/moonlight-list
This topic is locked and can not be replied to.