[patch] agdlr: Fix for Package.NormalizePath


#1

Hey,

This patch is part of a bunch I sent to Jimmy privately. But they
haven’t been applied, so am resending them here for review.

Package.NormalizePath transforms paths in the xap that use \ as a
directory separator to /. So use \ directly, instead of expecting it
to be the system directory separator.

Thanks,


#2

They are applied in the dev/mono branch, and I can apply them for 0.5.1.

~Jimmy
Sent from my phone


#3

Hey Jimmy,

On 4/1/09, Jimmy S. removed_email_address@domain.invalid wrote:

They are applied in the dev/mono branch, and I can apply them for 0.5.1.

Yeah, that would be cool. Is there any reason for not merging them in
origin?


#4

No major reason … they are small enough to be considered bug reports,
so I have no problem making the fixes. FYI, I have to be more careful
with substantial improvements/features, for the same reason that
IronRuby.dll or the DLR can’t accept contributions, but I hope to have a
clearer message on contributions in the future.

I don’t have moonlight on any of my machines to test it out (though I
trust you =P). Can you point me at instructions for setting up
Moonlight? I have a Ubuntu VM , or is there another distro I should use
since you’re testing more on it (SUSE I assume?).

~js


#5

On 4/1/09, Jimmy S. removed_email_address@domain.invalid wrote:

No major reason … they are small enough to be considered bug reports, so I have no problem making the fixes. FYI, I have to be more careful with substantial improvements/features, for the same reason that IronRuby.dll or the DLR can’t accept contributions, but I hope to have a clearer message on contributions in the future.

Cool. I don’t particularly care that my own personal patch is applied,
I care about having the feature working. So if you guys prefer bug
reports I can submit bugs reports.

I don’t have moonlight on any of my machines to test it out (though I trust you =P). Can you point me at instructions for setting up Moonlight? I have a Ubuntu VM , or is there another distro I should use since you’re testing more on it (SUSE I assume?).

I use openSUSE, but there’s no reason you couldn’t make it work
Ubuntu. You would have to setup Mono from svn, I suggest using:

http://www.mono-project.com/Parallel_Mono_Environments

There’s some instructions for Moonlight here:

http://www.mono-project.com/Moonlight#Developing_Moonlight

But it’s not always up to date as we are currently changing things a
lot. Don’t hesitate to ask on moonlight-list for help, or contact me
directly.

http://lists.ximian.com/mailman/listinfo/moonlight-list