Forum: IronRuby Code Review: DMO1

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2009-03-17 02:46
(Received via mailing list)
Attachment: DMO1.diff (30 KB)
tfpt review "/shelveset:DMO1;REDMOND\tomat"
  Comment  :
  -  Checks for an invalid number of arguments is passed to an attribute
setter/getter or struct field setter/getter.
  -  Implements correct splatting of arguments to Delegate constructor
and enables previously failing tests.
  -  Refactors RubyMethodGroupBase in preparation for obsolete API usage
removal.
  -  Fixes a comment and adds OBSOLETE comments to obsolete API of
MethodBinder and BindingTarget classes.

Tomas
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2009-03-17 17:27
(Received via mailing list)
In RubyClass.cs, there's an incorrect parameter passed to
SetWrongNumber:

var actualArgs = RubyMethodGroupBase.NormalizeArguments(metaBuilder,
args, SelfCallConvention.NoSelf, false, false);
if (actualArgs.Length == 1) {
    ...
} else {
    metaBuilder.SetWrongNumberOfArgumentsError(actualArgs.Length, 0);
<-- should be "1".
}

Looks good otherwise.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2009-03-17 18:44
(Received via mailing list)
Good catch. Will fix it in the next changeset.

Tomas
This topic is locked and can not be replied to.