Forum: IronRuby Code Review: NoSymbolId1

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2008-10-04 00:19
(Received via mailing list)
Attachment: NoSymbolId1.diff (400 KB)
tfpt review "/shelveset:NoSymbolId1;REDMOND\tomat"

  Removes SymbolIds from IronRuby compiler and runtime. Still keeps
SymbolId as a representation of Symbol Ruby class. The plan is to
replace SymbolId completely by System.String with interning table on
RubyContext (the integer values will be unique per script runtime). The
table will hold on additional information about the strings (encoding,
taint, instance variables, etc.).

Tomas
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2008-10-04 02:13
(Received via mailing list)
Changes look good, overall.  I like the approach.

In Tokenizer.cs, you replaced Symbols.Minus with the hardcoded "-" --
but Symbols.Minus has separately been redefined to "-".  Best to
continue to use the symbolic name, no?
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2008-10-04 02:48
(Received via mailing list)
OK, I've undone this line for now.

Tomas
This topic is locked and can not be replied to.