Code Review: NoSymbolId1


#1

tfpt review “/shelveset:NoSymbolId1;REDMOND\tomat”

Removes SymbolIds from IronRuby compiler and runtime. Still keeps
SymbolId as a representation of Symbol Ruby class. The plan is to
replace SymbolId completely by System.String with interning table on
RubyContext (the integer values will be unique per script runtime). The
table will hold on additional information about the strings (encoding,
taint, instance variables, etc.).

Tomas


#2

Changes look good, overall. I like the approach.

In Tokenizer.cs, you replaced Symbols.Minus with the hardcoded “-” –
but Symbols.Minus has separately been redefined to “-”. Best to
continue to use the symbolic name, no?


#3

OK, I’ve undone this line for now.

Tomas