We maybe need a quantity validator beside the current validates_length_of?

Detlef_R · March 30, 2015, 9:06am

I was talking with @sgrif about this in this
ticket Length validator only working with strings? · Issue #19570 · rails/rails · GitHub.

I think the current validates_length_of is pretty fine expressing thinks
like “the username is too long”, and the tokenizer is ideal for strings
situations but when it comes to arrays, collections, etc is really
strange
to override the message error and not being able to use some kind of
selector.

I did this gist to test this out

gist.github.com

https://gist.github.com/mmontossi/984f8ebfd50ea843b5f2

rails_19570.rb

module Validators
  extend ActiveSupport::Concern

  class CountValidator < ActiveModel::EachValidator

    def initialize(options)
      if range = (options.delete(:in) || options.delete(:within))
        options[:minimum] = range.min
        options[:maximum] = range.max
      end

This file has been truncated. show original

I was using this validator to thinks like:

validates_count_of :photos, within: 1…3, selector: ->(photos) {
photos.reject(&:marked_for_destruction?) }

This allows to have new errors.messages keys to express quantity:

errors.messages.too_many
errors.messages.too_few
errors.messages.wrong_count

Anyone shares this point of view?

unknown · April 1, 2015, 12:42am

at first glance it seems reasonable

Sent from my iPhone