Test_etc.rb の修正提案


#1

e$B6a1J$H?=$7$^$9!#e(B

e$B8=:_e(B trunk e$B$N%=!<%9%D%j!<$r%A%%C%/%"%&%H$7$F<j85$N4D6-$Ge(B
make test-all e$B$9$k$H3HD%%i%$%V%i%je(B etc e$B$N%F%9%H$Ge(B 2 failures
e$B$Ke(B
e$B$J$j$^$9e(B(e$BB>$K$b$"$j$^$9$,$H$j$"$($:e(B)e$B!#e(B

ldap e$B$rF3F~$7$F$$$Fe(B /etc/passwd e$B$He(B ldap e$B$Ge(B uid/gid
e$B$de(B name e$B$,=EJ#$9$ke(B
e$B%(%s%H%j$,$"$j!"$J$*$+$De(B gecos
e$B%U%#!<%k%I$J$I$K:90[$,$"$k$?$a$G$9!#e(B
e$B$=$&$$$&@_Dj$,$h$/$J$$$H$$$&$3$H$b$"$k$H$O;W$$$^$9$,!"e(B
getpwnam(3) e$BEy$O:G=i$K%^%C%A$7$?%(%s%H%j$rJV$9$h$&$J$N$G%F%9%H$be(B
e$B$=$N$h$&$K$9$k$N$O$I$&$G$7$g$&$+!#e(B

e$B0J>e!"$48!F$$/$@$5$$!#e(B
e$B0J2<e(B test_etc.rb e$B$N%Q%C%A$G$9!#e(B

Index: test/etc/test_etc.rb

test/etc/test_etc.rb (revision 22011)
+++ test/etc/test_etc.rb (working copy)
@@ -37,9 +37,9 @@
end

def test_getpwnam

  • passwd = []
  • Etc.passwd {|s| passwd << s }
  • passwd.each do |s|
  • passwd = {}
  • Etc.passwd {|s| passwd[s.name] = s unless passwd[s.name] }
  • passwd.values.each do |s|
    assert_equal(s, Etc.getpwnam(s.name))
    end
    end
    @@ -67,22 +67,26 @@
    end

def test_getgrgid

  • groups = []
  • groups = {}
    Etc.group do |s|
  •  groups << s
    
  •  unless groups[s.gid]
    
  •    groups[s.gid] = s
    
  •  end
    
    end
  • groups.each do |s|
  • groups.values.each do |s|
    assert_equal(s, Etc.getgrgid(s.gid))
    assert_equal(s, Etc.getgrgid) if Process.egid == s.gid
    end
    end

def test_getgrnam

  • groups = []
  • groups = {}
    Etc.group do |s|
  •  groups << s
    
  •  unless groups[s.gid]
    
  •    groups[s.name] = s
    
  •  end
    
    end
  • groups.each do |s|
  • groups.values.each do |s|
    assert_equal(s, Etc.getgrnam(s.name))
    end
    end

#2

e$B6a1J$H?=$7$^$9!#e(B

e$B$?$S$?$S$9$_$^$;$s!#e(B
e$B@h9o$O$j$D$1$?%Q%C%A$K4V0c$$$,$"$j$^$7$?$N$G:FAw$7$^$9!#e(B
e$B<:Ni$7$^$7$?!#e(B

e$B8=:_e(B trunk e$B$N%=!<%9%D%j!<$r%A%%C%/%"%&%H$7$F<j85$N4D6-$Ge(B
make test-all e$B$9$k$H3HD%%i%$%V%i%je(B etc e$B$N%F%9%H$Ge(B 2 failures
e$B$Ke(B
e$B$J$j$^$9e(B(e$BB>$K$b$"$j$^$9$,$H$j$"$($:e(B)e$B!#e(B

ldap e$B$rF3F~$7$F$$$Fe(B /etc/passwd e$B$He(B ldap e$B$Ge(B uid/gid
e$B$de(B name e$B$,=EJ#$9$ke(B
e$B%(%s%H%j$,$"$j!"$J$*$+$De(B gecos
e$B%U%#!<%k%I$J$I$K:90[$,$"$k$?$a$G$9!#e(B
e$B$=$&$$$&@_Dj$,$h$/$J$$$H$$$&$3$H$b$"$k$H$O;W$$$^$9$,!"e(B
getpwnam(3) e$BEy$O:G=i$K%^%C%A$7$?%(%s%H%j$rJV$9$h$&$J$N$G%F%9%H$be(B
e$B$=$N$h$&$K$9$k$N$O$I$&$G$7$g$&$+!#e(B

e$B0J>e!"$48!F$$/$@$5$$!#e(B
e$B0J2<e(B test_etc.rb e$B$N%Q%C%A$G$9!#e(B

Index: test/etc/test_etc.rb

test/etc/test_etc.rb (revision 22011)
+++ test/etc/test_etc.rb (working copy)
@@ -37,9 +37,9 @@
end

def test_getpwnam

  • passwd = []
  • Etc.passwd {|s| passwd << s }
  • passwd.each do |s|
  • passwd = {}
  • Etc.passwd {|s| passwd[s.name] = s unless passwd[s.name] }
  • passwd.values.each do |s|
    assert_equal(s, Etc.getpwnam(s.name))
    end
    end
    @@ -67,22 +67,26 @@
    end

def test_getgrgid

  • groups = []
  • groups = {}
    Etc.group do |s|
  •  groups << s
    
  •  unless groups[s.gid]
    
  •    groups[s.gid] = s
    
  •  end
    
    end
  • groups.each do |s|
  • groups.values.each do |s|
    assert_equal(s, Etc.getgrgid(s.gid))
    assert_equal(s, Etc.getgrgid) if Process.egid == s.gid
    end
    end

def test_getgrnam

  • groups = []
  • groups = {}
    Etc.group do |s|
  •  groups << s
    
  •  unless groups[s.name]
    
  •    groups[s.name] = s
    
  •  end
    
    end
  • groups.each do |s|
  • groups.values.each do |s|
    assert_equal(s, Etc.getgrnam(s.name))
    end
    end

#3

e$B1sF#$G$9!#e(B

2009/02/03 19:31 Tomoyuki C.
removed_email_address@domain.invalid:

e$B8=:_e(B trunk e$B$N%=!<%9%D%j!<$r%A%%C%/%"%&%H$7$F<j85$N4D6-$Ge(B
make test-all e$B$9$k$H3HD%%i%$%V%i%je(B etc e$B$N%F%9%H$Ge(B 2 failures e$B$Ke(B
e$B$J$j$^$9e(B(e$BB>$K$b$"$j$^$9$,$H$j$"$($:e(B)e$B!#e(B

ldap e$B$rF3F~$7$F$$$Fe(B /etc/passwd e$B$He(B ldap e$B$Ge(B uid/gid e$B$de(B name e$B$,=EJ#$9$ke(B
e$B%(%s%H%j$,$"$j!"$J$*$+$De(B gecos e$B%U%#!<%k%I$J$I$K:90[$,$"$k$?$a$G$9!#e(B
e$B$=$&$$$&@_Dj$,$h$/$J$$$H$$$&$3$H$b$"$k$H$O;W$$$^$9$,!"e(B
getpwnam(3) e$BEy$O:G=i$K%^%C%A$7$?%(%s%H%j$rJV$9$h$&$J$N$G%F%9%H$be(B
e$B$=$N$h$&$K$9$k$N$O$I$&$G$7$g$&$+!#e(B

e$B$"$j$,$H$&$4$6$$$^$9!#e(B
e$B$3$NLdBj$OG<1$7$F$$$?$s$G$9$,!"=EMW$8$c$J$5$=$&$@$C$?$N$GJ|CV$7$F$^$7$?!#e(B
e$B$9$_$^$;$s!#$$$?$@$$$?%Q%C%A$GD>$k$3$H$r3NG$7$?$N$G!"E,MQ$7$F$*$-$^$9!#e(B