Kouhei S. wrote:
Please commit. If there is a bug, we will fix it after your
I discovered an issue with the patch. Two .pc files were renamed:
libgnome-2.0-ruby.pc -> libgnomeui-2.0-ruby.pc and poppler-ruby.pc ->
The problem is that create_pkg_config_file() requires that the ruby .pc
filename match that of the respective C library with the ‘-ruby.pc’
suffix. In the first case, Ruby/Gnome2 binds both libgnome-2.0 and
libgnomeui-2.0; in the second, Ruby/Poppler bindings libpoppler-glib but
the module is simply called ‘poppler’. Furthermore, with gtkmozembed,
the .pc file may be any of 5 different names but the ruby module has the
same name regardless of which it is built against.
Perhaps for consistency we should consider changing the naming scheme of
the .pc files:
def create_pkg_config_file(ruby_mod_name, c_package, version=nil)
version ||= PKGConfig.modversion c_package
pc_file = File.new(‘ruby-’ + ruby_mod_name + ‘.pc’, ‘w+’, 0644)
with each module doing:
create_pkg_config_file(PACKAGE_NAME, PACKAGE_ID, ruby_gnome2_version)
thereby creating ruby-glib2.pc, ruby-atk.pc, ruby-poppler.pc, etc.
OTOH, as there was already one (unstable) release with the existing
names, would it be too late to change this?