Some thoughts on out of tree modules and cmake files

Hi,

at the moment each out of tree module has it’s one cmake/Modules path,
containing some cmake macros, mainly copied from some gnuradio source
tree.

As gnuradio development proceeds, cmake modules may be updated. It’s not
always necessary but perhaps good practice to keep the out of tree cmake
modules in sync.

As the number of oot- modules raises that means a lot of work.

As each oot module needs a gnuradio installation , why not to install
the complete cmake path together with gnuradio and reference these
modules in the oot CMakeLists.txt. As far as I can see only only two
lines in the main CMakeLists.txt file are effected.

The oot modules source would always use updated cmake files and if you
need macros not provided by gnuradio you can still keep them with your
module.

– Volker

at the moment each out of tree module has it’s one cmake/Modules path,
containing some cmake macros, mainly copied from some gnuradio source tree.

GnuRadio already installs the required CMakefiles modules globally so
AFAIK, OOT modules are free to use them.

And it’s definitely a goal toward things are trending but there are
still some reason to keep local copies.

One reason OOT module would choose to keep a local copy is to be
compatible with older GR. For instance, in my OOT projects, I keep the
local FindGnuradio.cmake instead of using GrConfig.cmake because it
was broken until 3.7.2.1 …

For some other cmake modules, they’re not really “meant” to be used
outside of GR itself. Like the GrComponent.cmake . I know several
modules using it, but it’s been slightly modified to fit the
particular need of that OOT project because the default one is not
customizable enough (because not meant for anything by GR internal)

Cheers,

Sylvain

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Also, usually to build an OOT-Module you shouldn’t need the whole GR
tree, but only the headers that had been used to build the
gnuradio-libraries as well as the libraries to link against.

So, when introducing another external dependency for OOT modules we
kind of make packaging harder. I don’t know if it’s worth the effort;
then, again, I’ve never built any gnuradio-devel (or the like) fedora
or debian/ubuntu package. It certainly would not hurt a development
machine badly to install the CMake modules.
Then, again, it would be preferable to have these modules installed
somewhere where CMake would automatically look for them, calling for a
package gnuradio-cmake-modules (or something of the like) on its own.

Greetings,
Marcus

On 28.01.2014 13:26, Sylvain M. wrote:

One reason OOT module would choose to keep a local copy is to be

Cheers,

Sylvain

_______________________________________________ Discuss-gnuradio
mailing list [email protected]
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJS56RYAAoJEAFxB7BbsDrL47YIAKLZpBOoyxrvlP8HVjjAFKmq
MEAs3578oPSxjQOAb3DK8+G8JaUSOIi+cBqcyUDfNQsQyLqXpU5qWM2l87WigV9e
UpUrq2ua59waZOXcBTYLOiMSyW/NID0nlv58beG5VZK0HsdmkFYcdAmh54FAwEfm
GKdvVORCi1msd0TNYWkIRBfn06hbUj5QMLBOBUe8gIN/0wSi5OPoqHbnqsdOpS5c
3kEC6WWwRSbWKaG0IOvvvvffD/jipx7AyuOS50cEFFZV9Y5eJePeuimbG1uAWuqE
YzeItyRt1npLZAPUopyHmWlqtP7oaCd7YL4+Oj2g1TwTuML7O5abJf0QbeKooc4=
=a3KX
-----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thinking about it, if we’re exchanging thoughts, I think the CMake
Modules would make a fine submodule in the GR main tree, as well as in
OOT modules.
But that would introduce to initializing and updating the cmake
submodule after cloning the gnuradio git repo; and that would make
installation more complicated. Maybe this could be fixed from within a
CMakeList, but then you need internet connectivity at first compile
time :frowning:

On 28.01.2014 13:36, Marcus M. wrote:

somewhere where CMake would automatically look for them, calling

GnuRadio already installs the required CMakefiles modules
For some other cmake modules, they’re not really “meant” to be

_______________________________________________ Discuss-gnuradio
mailing list [email protected]
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

_______________________________________________ Discuss-gnuradio
mailing list [email protected]
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJS56j9AAoJEAFxB7BbsDrLBiAH/if3lZ43hIYnltOrpBrRocI6
YdAeEqcut/N3PNlnCcK/8mCTsqAwzavoRd3NucJGCVRS83lTUBPD9fDW6QaGWTVw
KLuYwwS3iqji+Y5dNnW0gP3AwLOpNtej99Q3XfiIuW63GHUakGPfMhmgxmwWDIv8
1rd2P2+hoq0FFXO9J6DYi8md2Mvrh0apni5XOw5xL9HwaictfjgXGYOz2OtT823m
V3FzZ3rf/1fHYpyD+3kdg3X1xBd8ZYHP5La1xThx/oAnI3mzoZ5GsSoyeQsUfgWH
abEQzwO+i13ARCDDGUnUDftXw+NYGSWFLM+ATXs5CI+LgcMQWcqkF74uLwXIIQ4=
=e+CF
-----END PGP SIGNATURE-----

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs