Small fix for some GtkAction subclasses

Desktop Ruby-Gnome 2
1

Attached is a patch which fixes some issues I ran into trying to use
Gtk::RadioAction and Gtk::ToggleAction in a program I’m working on. It
mostly just brings the initializer methods into line to match the
Gtk::Action initialize methods.

Without these patches, you can’t pass nil for the tooltip parameter or
the stock_id parameter in Gtk::ToggleAction.new or Gtk::RadioAction.new.

-pete

2

Hi,

Thanks. Applied to CVS.

On Sat, 9 Dec 2006 20:54:29 -0800
Peter J. [email protected] wrote:

Attached is a patch which fixes some issues I ran into trying to use
Gtk::RadioAction and Gtk::ToggleAction in a program I’m working on. It
mostly just brings the initializer methods into line to match the
Gtk::Action initialize methods.

Without these patches, you can’t pass nil for the tooltip parameter or
the stock_id parameter in Gtk::ToggleAction.new or Gtk::RadioAction.new.

-pete

Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net’s Techsay panel and you’ll get the chance to share
your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

3

Peter J. [2006-12-09 20:54]:

[snip]

 if (TYPE(stock_id) == T_STRING){
     gstock = RVAL2CSTR(stock_id);
  • } else {
  • } else if (TYPE(stock_id) == T_STRING){
    gstock = rb_id2name(SYM2ID(stock_id));
    }

This part of the patch looks suspicious :slight_smile:
Maybe the second line should check for T_SYMBOL?

Regards,
Tilman

4

Hi,

Yes. I noticed it and I fixed it before I checked it in CVS.

On Sun, 10 Dec 2006 16:07:19 +0100
Tilman S. [email protected] wrote:

This part of the patch looks suspicious :slight_smile:

Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net’s Techsay panel and you’ll get the chance to share
your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

5

On Sun, Dec 10, 2006 at 04:07:19PM +0100, Tilman S. wrote:

This part of the patch looks suspicious :slight_smile:
Maybe the second line should check for T_SYMBOL?

Oy! Indeed. Glad it got caught and fixed before getting commited. Sorry
about that.

-pete

Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net’s Techsay panel and you’ll get the chance to share
your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV