RubySpec changes

I’m syncing up the copy of Rubyspec in TFS/SVN with the copy in Git.
I’d like to get a code review of the changes. Eventually this will be
automated, but for now, I’m attaching them directly.

Question: Does the attached format work? It’s the format output by git
when you run git format-patch. It’s basically a diff, but it’s different
enough that I want to know. I can change to diff’s if needed.

JD
http://blog.jredville.com

Why not fork the RubySpec project on GitHub, apply your patches and
point us
at your forked GIT repository? That way we can easily see the changes
using
the tools on GitHub.

Pete

From: [email protected]
[mailto:[email protected]] On Behalf Of Jim D.
Sent: Wednesday,09 July 09, 2008 21:21
To: [email protected]; IronRuby External Code R.;
Srivatsn
Narayanan
Subject: [Ironruby-core] RubySpec changes

I’m syncing up the copy of Rubyspec in TFS/SVN with the copy in Git.
I’d
like to get a code review of the changes. Eventually this will be
automated,
but for now, I’m attaching them directly.

Question: Does the attached format work? It’s the format output by git
when
you run git format-patch. It’s basically a diff, but it’s different
enough
that I want to know. I can change to diff’s if needed.


JD

http://blog.jredville.com

Good idea. I’m going to start doing that, but here’s an update on what
I’ve done while I move my get repo’s origin. I’ve already sent some of
the out, but I resent all just to be safe.

JD

From: [email protected]
[mailto:[email protected]] On Behalf Of Peter Bacon
Darwin
Sent: Wednesday, July 09, 2008 1:36 PM
To: [email protected]
Subject: Re: [Ironruby-core] RubySpec changes

Why not fork the RubySpec project on GitHub, apply your patches and
point us at your forked GIT repository? That way we can easily see the
changes using the tools on GitHub.
Pete

From: [email protected]
[mailto:[email protected]] On Behalf Of Jim D.
Sent: Wednesday,09 July 09, 2008 21:21
To: [email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: [Ironruby-core] RubySpec changes

I’m syncing up the copy of Rubyspec in TFS/SVN with the copy in Git.
I’d like to get a code review of the changes. Eventually this will be
automated, but for now, I’m attaching them directly.

Question: Does the attached format work? It’s the format output by git
when you run git format-patch. It’s basically a diff, but it’s different
enough that I want to know. I can change to diff’s if needed.

JD
http://blog.jredville.com

I went over these face to face with John, but for those who want, I’ve
also now pushed ( and will in the future) these to my github fork:
http://github.com/jredville/rubyspec.

You can check them out there.

JD

From: [email protected]
[mailto:[email protected]] On Behalf Of Jim D.
Sent: Thursday, July 10, 2008 12:45 PM
To: removed_[email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: Re: [Ironruby-core] RubySpec changes

Good idea. I’m going to start doing that, but here’s an update on what
I’ve done while I move my get repo’s origin. I’ve already sent some of
the out, but I resent all just to be safe.

JD

From: [email protected]
[mailto:[email protected]] On Behalf Of Peter Bacon
Darwin
Sent: Wednesday, July 09, 2008 1:36 PM
To: [email protected]
Subject: Re: [Ironruby-core] RubySpec changes

Why not fork the RubySpec project on GitHub, apply your patches and
point us at your forked GIT repository? That way we can easily see the
changes using the tools on GitHub.
Pete

From: [email protected]
[mailto:[email protected]] On Behalf Of Jim D.
Sent: Wednesday,09 July 09, 2008 21:21
To: [email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: [Ironruby-core] RubySpec changes

I’m syncing up the copy of Rubyspec in TFS/SVN with the copy in Git.
I’d like to get a code review of the changes. Eventually this will be
automated, but for now, I’m attaching them directly.

Question: Does the attached format work? It’s the format output by git
when you run git format-patch. It’s basically a diff, but it’s different
enough that I want to know. I can change to diff’s if needed.

JD
http://blog.jredville.com

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs