[ruby-trunk - Bug #7111][Open] New build option to enable/disable global method caching

Ruby Development
1

Issue #7111 has been reported by shugo (Shugo M.).

Bug #7111: New build option to enable/disable global method caching

Author: shugo (Shugo M.)
Status: Open
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category: core
Target version:
ruby -v: ruby 2.0.0dev (2012-10-05 trunk 37093) [i686-linux]

Ruby has a build option to enable/disable inline method caching
(OPT_INLINE_METHOD_CACHE), but has no such option for global method
caching.
How about to add a new build option OPT_GLOBAL_METHOD_CACHE?

I’ve attached a patch to add that option.

2

(2012/10/06 11:19), shugo (Shugo M.) wrote:

Ruby has a build option to enable/disable inline method caching
(OPT_INLINE_METHOD_CACHE), but has no such option for global method caching.
How about to add a new build option OPT_GLOBAL_METHOD_CACHE?

I’ve attached a patch to add that option.

I don’t have any objection.
Where is a patch?

3

Issue #7111 has been updated by shugo (Shugo M.).

File opt_global_method_cache.diff added

ko1 (Koichi Sasada) wrote:

I don’t have any objection.
Where is a patch?

I forgot to attach it:(
Please see opt_global_method_cache.diff attached.

Bug #7111: New build option to enable/disable global method caching

Author: shugo (Shugo M.)
Status: Open
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category: core
Target version:
ruby -v: ruby 2.0.0dev (2012-10-05 trunk 37093) [i686-linux]

Ruby has a build option to enable/disable inline method caching
(OPT_INLINE_METHOD_CACHE), but has no such option for global method
caching.
How about to add a new build option OPT_GLOBAL_METHOD_CACHE?

I’ve attached a patch to add that option.

4

Issue #7111 has been updated by shugo (Shugo M.).

ko1 (Koichi Sasada) wrote:

(2012/10/06 15:31), shugo (Shugo M.) wrote:

I forgot to attach it:(
Please see opt_global_method_cache.diff attached.

It is okay. But I recommend that only method search at the the
`rb_method_entry_get_with_omod’ should be disable to measure and compare
performance.

I’ve committed the fix with the above change.

Bug #7111: New build option to enable/disable global method caching

Author: shugo (Shugo M.)
Status: Closed
Priority: Normal
Assignee: ko1 (Koichi Sasada)
Category: core
Target version:
ruby -v: ruby 2.0.0dev (2012-10-05 trunk 37093) [i686-linux]

Ruby has a build option to enable/disable inline method caching
(OPT_INLINE_METHOD_CACHE), but has no such option for global method
caching.
How about to add a new build option OPT_GLOBAL_METHOD_CACHE?

I’ve attached a patch to add that option.

5

(2012/10/06 15:31), shugo (Shugo M.) wrote:

I forgot to attach it:(
Please see opt_global_method_cache.diff attached.

It is okay. But I recommend that only method search at the the
`rb_method_entry_get_with_omod’ should be disable to measure and compare
performance.