On Wed, Sep 23, 2009 at 02:14, Kouhei S. [email protected] wrote:
I looked Ruby/GIO source and noticed that it doesn’t follow
the Ruby-GNOME2 style guideline:
In what respect? Iâ€™ve followed it as far as I can tell.
And please don’t use DECLARE*, DEF_, SCAN_ family
macros. Please keep coding style with other bindings.
I realize that this may be controversial, but itâ€™s so much simpler
this way and avoids a lot of errors by not having to repeat the same
junk every time. The bindings are already 5338 lines. Not using
these macros will make it a lot larger and, in my opinion, harder to
I mean, take functions that use SCAN_3_ARGS_WITH_BLOCK:
That would be
rbgio_im_next_files_async(int argc, VALUE *arg, VALUE self)
rb_scan_args(argc, argv, "12&",
num_files = NUM2INT(rbnum_files);
io_priority = RVAL2IOPRIORITYDEFAULT(rbio_priority);
cancellable = RVAL2GCANCELLABLE(rbcancellable);
OK, you donâ€™t always need to do all the NUM2INT (and similar), but
sometimes order is important and then we have a problem if it is done
in different ways.
If Ruby/GIO doesn’t follow the Ruby-GNOME2 style guideline,
we may remove it from the Ruby-GNOME2 project. :<
I am sorry to say that I donâ€™t have time to fix this right now. Is
someone else up to the task?