Review: Misc ActiveRecord bug fixes

Ruby IronRuby
1

Fix bug in LightLambda.CreateCustomDelegate - it was not dealing with
valuetype arguments.
Partial implementation of Kernel#test
Effectively call Thread.critical=false when a thread exits after having
done Thread.critical=true. monitor.rb in the standard library uses this
pattern
Adds support for YAML::Omap (used in ActiveRecord) by doing “require
‘yaml/types.rb’” in our yaml.rb
Changes path in RakeTests.rb
Deletes redist-libs/ruby/site_ruby/1.8/ubygems.rb which seems like it
was added by mistake

Files affected:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/kernel/test_tags.txt
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/each_spec.rbhttp://github.com/shri/ironruby/tree/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/each_spec.rb
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/element_reference_spec.rbhttp://github.com/shri/ironruby/tree/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/element_reference_spec.rb
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/element_set_spec.rbhttp://github.com/shri/ironruby/tree/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/element_set_spec.rb
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/has_key_spec.rbhttp://github.com/shri/ironruby/tree/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/has_key_spec.rb
*
Merlin/External.LCA_RESTRICTED/Languages/Ruby/redist-libs/ruby/site_ruby/1.8/ubygems.rb
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-6
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ThreadOps.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-7
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-8
*
Merlin/Main/Languages/Ruby/Libs/yaml.rbhttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-9
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyContext.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-10
*
Merlin/Main/Languages/Ruby/Tests/Scripts/RakeTests.rbhttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-11
*
Merlin/Main/Runtime/Microsoft.Scripting/Interpreter/LightLambda.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-12

Thanks,
Shri

2

Kernel.cs: switch ((char)cmd) will blow up if char > 0xffff or < 0.
There is an implicit conversion from int to char, so the cast is
unnecessary. It seems that Ruby uses (cmd & 0xff) as a value of the
command.

Other than that looks good.

Tomas

From: Shri B.
Sent: Thursday, June 25, 2009 10:22 AM
To: [email protected]
Cc: IronRuby External Code R.
Subject: Review: Misc ActiveRecord bug fixes

Fix bug in LightLambda.CreateCustomDelegate - it was not dealing with
valuetype arguments.
Partial implementation of Kernel#test
Effectively call Thread.critical=false when a thread exits after having
done Thread.critical=true. monitor.rb in the standard library uses this
pattern
Adds support for YAML::Omap (used in ActiveRecord) by doing “require
‘yaml/types.rb’” in our yaml.rb
Changes path in RakeTests.rb
Deletes redist-libs/ruby/site_ruby/1.8/ubygems.rb which seems like it
was added by mistake

Files affected:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/kernel/test_tags.txt
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/each_spec.rbhttp://github.com/shri/ironruby/tree/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/each_spec.rb
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/element_reference_spec.rbhttp://github.com/shri/ironruby/tree/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/element_reference_spec.rb
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/element_set_spec.rbhttp://github.com/shri/ironruby/tree/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/element_set_spec.rb
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/has_key_spec.rbhttp://github.com/shri/ironruby/tree/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/yaml/omap/has_key_spec.rb
*
Merlin/External.LCA_RESTRICTED/Languages/Ruby/redist-libs/ruby/site_ruby/1.8/ubygems.rb
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-6
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ThreadOps.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-7
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-8
*
Merlin/Main/Languages/Ruby/Libs/yaml.rbhttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-9
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyContext.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-10
*
Merlin/Main/Languages/Ruby/Tests/Scripts/RakeTests.rbhttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-11
*
Merlin/Main/Runtime/Microsoft.Scripting/Interpreter/LightLambda.cshttp://github.com/shri/ironruby/commit/000ccff01b5a5cb53c140e94dc3f4c2e34806ba2#diff-12

Thanks,
Shri