Review: Marshal bug


#1

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
‘2009-03-22 00:00:00\s\t’") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set

Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0
*
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6
*
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7
*
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8
*
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9
*
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10
*
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11
*
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12

Thanks,
Shri


#2

Library changes look good.

Tomas

From: Shri B.
Sent: Thursday, March 26, 2009 4:35 PM
To: IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636
http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
‘2009-03-22 00:00:00\s\t’") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set

Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0
*
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6
*
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7
*
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8
*
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9
*
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10
*
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11
*
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12

Thanks,
Shri


#3

Test and batch changes look good.

JD

From: Tomas M.
Sent: Friday, March 27, 2009 12:59 PM
To: Shri B.; IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: RE: Review: Marshal bug

Library changes look good.

Tomas

From: Shri B.
Sent: Thursday, March 26, 2009 4:35 PM
To: IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636
http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
‘2009-03-22 00:00:00\s\t’") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set

Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0
*
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3
*
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rbhttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cshttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6
*
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7
*
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8
*
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9
*
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10
*
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11
*
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bathttp://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12

Thanks,
Shri