Review: Fix for TCPSocket.new

Ruby IronRuby
1

With the memcache-client gem installed, the Rails tests fail to startup
as
memcache does TCPSocket.new(addr, port, 0) and we were not handling the
third argument

Files changed:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/socket/tcpsocket/new_tags.txthttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-0
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/socket/tcpsocket/open_tags.txthttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-1
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/socket/fixtures/classes.rbhttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-2
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/socket/tcpsocket/shared/new.rbhttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-3
*
Merlin/Main/Languages/Ruby/ClassInitGenerator/ClassInitGenerator.csprojhttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-4
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cshttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-5
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/socket/TCPSocket.cshttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-6
Thanks,
Shri

2

This looks mostly good. My only comment is that I would suggest
combining the it “allows local_port to be 0 when local_host is not
specified” do and it “requires local_port to be 0 when local_host is not
specified” specs, since, IMHO, the requirement/allowance is different
views on the same facet of behavior.

JD

…there is no try

From: Shri B.
Sent: Thursday, April 30, 2009 1:45 PM
To: [email protected]
Cc: IronRuby External Code R.
Subject: Review: Fix for TCPSocket.new

With the memcache-client gem installed, the Rails tests fail to startup
as
memcache does TCPSocket.new(addr, port, 0) and we were not handling the
third argument

Files changed:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/socket/tcpsocket/new_tags.txthttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-0
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/socket/tcpsocket/open_tags.txthttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-1
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/socket/fixtures/classes.rbhttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-2
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/socket/tcpsocket/shared/new.rbhttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-3
*
Merlin/Main/Languages/Ruby/ClassInitGenerator/ClassInitGenerator.csprojhttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-4
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cshttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-5
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/socket/TCPSocket.cshttp://github.com/shri/ironruby/commit/8c00011ba4260314e9ebc70ec317d1c49eb8d755#diff-6
Thanks,
Shri