Review: Array\to_s fix for : properly handles recursive array


#1

http://github.com/tnachen/ironruby/commit/eeaf82a8d833c763fc617b602cd7415cb228a0f6

Modified IListOps to fix the recursive array problem during to_s call.

It used to only print the values in the array, and skip over arrays in
the array that contains the same values.

However, to conform with mri, I modified it so it will walk into the
array and print the values for only one level deep, then print the
remaining arrays with “[…]”.

Files Changed:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/array/to_s_tags.txt
(deleted)
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/env/clear_tags.txt
(deleted)
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs
(modified)

Thank you!
Tim


#2

Forgot to mention that I deleted the tag files that has no more tags in
it.

Tim

From: removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Tim C. (SDO)
Sent: Monday, May 11, 2009 6:02 PM
To: removed_email_address@domain.invalid
Subject: [Ironruby-core] Review: Array\to_s fix for : properly handles
recursive array

http://github.com/tnachen/ironruby/commit/eeaf82a8d833c763fc617b602cd7415cb228a0f6

Modified IListOps to fix the recursive array problem during to_s call.

It used to only print the values in the array, and skip over arrays in
the array that contains the same values.

However, to conform with mri, I modified it so it will walk into the
array and print the values for only one level deep, then print the
remaining arrays with “[…]”.

Files Changed:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/array/to_s_tags.txt
(deleted)
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/env/clear_tags.txt
(deleted)
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs
(modified)

Thank you!
Tim


#3

Hello Tim,
I would like to share experience about code convention with you. You
should set a braces on Same Line option
(http://www.knowdotnet.com/articles/toolsoptionsnewlinesbraces.html
).

Cheers,
-Jirapong


#4

Looks good!

From: removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Tim C. (SDO)
Sent: Tuesday, May 12, 2009 12:12 AM
To: removed_email_address@domain.invalid
Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly
handles recursive array

It is the first time I modify the ruby source :slight_smile: so sorry for the
ignorance.

I would change those and push them again.

Thanks for the feedback!

Tim


From: removed_email_address@domain.invalid
[removed_email_address@domain.invalid] on behalf of
removed_email_address@domain.invalid [removed_email_address@domain.invalid]
Sent: Monday, May 11, 2009 7:11 PM
To: removed_email_address@domain.invalid
Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly
handles recursive array
Hello Tim,
I would like to share experience about code convention with you. You
should set a braces on Same Line option
(http://www.knowdotnet.com/articles/toolsoptionsnewlinesbraces.html).

Cheers,
-Jirapong

On May 12, 2009, at 8:03 AM, Tim C. (SDO) wrote:

Forgot to mention that I deleted the tag files that has no more tags in
it.

Tim

From:
removed_email_address@domain.invalidmailto:removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Tim C. (SDO)
Sent: Monday, May 11, 2009 6:02 PM
To: removed_email_address@domain.invalidmailto:removed_email_address@domain.invalid
Subject: [Ironruby-core] Review: Array\to_s fix for : properly handles
recursive array

http://github.com/tnachen/ironruby/commit/eeaf82a8d833c763fc617b602cd7415cb228a0f6

Modified IListOps to fix the recursive array problem during to_s call.

It used to only print the values in the array, and skip over arrays in
the array that contains the same values.

However, to conform with mri, I modified it so it will walk into the
array and print the values for only one level deep, then print the
remaining arrays with “[…]”.

Files Changed:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/array/to_s_tags.txt
(deleted)
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/env/clear_tags.txt
(deleted)
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs
(modified)

Thank you!
Tim


#5

Looks good.

From: removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Tim C. (SDO)
Sent: Monday, May 11, 2009 6:03 PM
To: removed_email_address@domain.invalid
Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly
handles recursive array

Forgot to mention that I deleted the tag files that has no more tags in
it.

Tim

From: removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Tim C. (SDO)
Sent: Monday, May 11, 2009 6:02 PM
To: removed_email_address@domain.invalid
Subject: [Ironruby-core] Review: Array\to_s fix for : properly handles
recursive array

http://github.com/tnachen/ironruby/commit/eeaf82a8d833c763fc617b602cd7415cb228a0f6

Modified IListOps to fix the recursive array problem during to_s call.

It used to only print the values in the array, and skip over arrays in
the array that contains the same values.

However, to conform with mri, I modified it so it will walk into the
array and print the values for only one level deep, then print the
remaining arrays with “[…]”.

Files Changed:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/array/to_s_tags.txt
(deleted)
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/env/clear_tags.txt
(deleted)
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs
(modified)

Thank you!
Tim


#6

It is the first time I modify the ruby source :slight_smile: so sorry for the
ignorance.

I would change those and push them again.

Thanks for the feedback!

Tim


From: removed_email_address@domain.invalid
[removed_email_address@domain.invalid] on behalf of
removed_email_address@domain.invalid [removed_email_address@domain.invalid]
Sent: Monday, May 11, 2009 7:11 PM
To: removed_email_address@domain.invalid
Subject: Re: [Ironruby-core] Review: Array\to_s fix for : properly
handles recursive array

Hello Tim,
I would like to share experience about code convention with you. You
should set a braces on Same Line option
(http://www.knowdotnet.com/articles/toolsoptionsnewlinesbraces.html).

Cheers,
-Jirapong

On May 12, 2009, at 8:03 AM, Tim C. (SDO) wrote:

Forgot to mention that I deleted the tag files that has no more tags in
it.

Tim

From:
removed_email_address@domain.invalidmailto:removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Tim C. (SDO)
Sent: Monday, May 11, 2009 6:02 PM
To: removed_email_address@domain.invalidmailto:removed_email_address@domain.invalid
Subject: [Ironruby-core] Review: Array\to_s fix for : properly handles
recursive array

http://github.com/tnachen/ironruby/commit/eeaf82a8d833c763fc617b602cd7415cb228a0f6

Modified IListOps to fix the recursive array problem during to_s call.

It used to only print the values in the array, and skip over arrays in
the array that contains the same values.

However, to conform with mri, I modified it so it will walk into the
array and print the values for only one level deep, then print the
remaining arrays with “[…]”.

Files Changed:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/array/to_s_tags.txt
(deleted)
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/env/clear_tags.txt
(deleted)
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs
(modified)

Thank you!
Tim