Regexp matching in a block of code

I am trying to create a script that will allow me to compare email
addresses with a list of domains to see if they match. If they don’t
match then everything is good to go, but if they do match, I want to
be able to delete them or move them out of the list.

The code that I wrote gives the following when its ran:
TypeError: type mismatch: String given

method =~ in untitled document at line 7
at top level in untitled document at line 7
method each in untitled document at line 5
at top level in untitled document at line 5
method each in untitled document at line 4
at top level in untitled document at line 4
Program exited.

I know my issue is with this particular line: if(add =~
Regexp.escape(comp))
But I am not sure where to find out or how to resolve it

Any help again is appreciated.

Code:

addresses = [“[email protected]”, “[email protected]”, “[email protected]”]
competitors = [“bar.com”, “bar1.com”, “bar4.com”]

addresses.each do |add|
competitors.each do |comp|
puts “Checking Competitor: #{comp}”
if(add =~ Regexp.escape(comp))
puts “#{check} matched”
else
puts “No Match”
end
end
end

On Feb 5, 10:00 pm, Vell [email protected] wrote:

method each in untitled document at line 5

else
  puts "No Match"
end

end
end

Sorry guys, Messed up on initial insert of the code. Here is the code
as follows:

Code:
addresses = [“[email protected]”, “[email protected]”, “[email protected]”]
competitors = [“bar.com”, “bar1.com”, “bar4.com”]
addresses.each do |add|
competitors.each do |comp|
puts “Checking Competitor: #{comp}”
if(add =~ Regexp.escape(comp))
puts “matched”
else
puts “No Match”
end
end
end

Lovell Mcilwain wrote:

addresses = [“[email protected]”, “[email protected]”, “[email protected]”]
competitors = [“bar.com”, “bar1.com”, “bar4.com”]
addresses.each do |add|
competitors.each do |comp|
puts “Checking Competitor: #{comp}”
if(add =~ Regexp.escape(comp))
puts “matched”
else
puts “No Match”
end
end
end

Try this:

add = “[email protected]
comp = “bar.com

if add =~ comp
puts ‘matched’
else
puts ‘no match’
end

On 06.02.2008, at 04:04, Vell wrote:

end
end
end

As you can see in the documentation Regexp.escape returns a string
and Regexp.new returns an regexp.

If you write

if(add =~ %r { Regexp.escape(comp)) }

or

if(add =~ Regexp.new( Regexp.escape(comp)) )

you code works for me.

  • Karl-Heinz

On 06.02.2008, at 08:26, Karl-Heinz Wild wrote:

else

if(add =~ %r { Regexp.escape(comp)) }

or

if(add =~ Regexp.new( Regexp.escape(comp)) )

you code works for me.

You can also write

if Regexp.new( comp ).match( add )

  • Karl-Heinz

2008/2/6, Vell [email protected]:

at top level in untitled document at line 7
Any help again is appreciated.
puts “#{check} matched”
addresses = [“[email protected]”, “[email protected]”, “[email protected]”]
end
There are a few things to say about this approach. First, it seems no
regular expression is needed here - at least not for matching.
Second, using Set is significantly more efficient. Here’s one way to
do it:

competitors = [“bar.com”, “bar1.com”, “bar4.com”].to_set
addresses = [“[email protected]”, “[email protected]”, “[email protected]”]
dirty, clean = addresses.partition {|adr| competitors.include?
adr[/@(\S+)/, 1].downcase}

Now, if you are reading a large number of addresses from a file, you
could do

competitors = [“bar.com”, “bar1.com”, “bar4.com”].to_set
dirty = []
clean = []

File.foreach “adresses.txt” do |line|
adr = line[/\[email protected]\S+/] # this should be improved
(competitors.include? adr[/@(\S+)/, 1].downcase ?
dirty : clean) << adr
end

Kind regards

robert

On Feb 5, 9:00 pm, Vell [email protected]lid wrote:

method each in untitled document at line 5

else
  puts "No Match"
end

end
end

Trivial.

E:>irb --prompt xmp
addresses = [“[email protected]”, “[email protected]”, “[email protected]”]
==>[“[email protected]”, “[email protected]”, “[email protected]”]
competitors = [“bar.com”, “bar1.com”, “bar4.com”]
==>[“bar.com”, “bar1.com”, “bar4.com”]
addresses.map{|x| x.split(’@’).last } & competitors
==>[“bar1.com”]

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs