Redefining initialize while staying -w clean


#1

Hi all,

Is it possible to redefine initialize and stay -w clean? In win32-file-
stat, I’ve redefined initialize to suit my needs for MS Windows.

If I do “undef_method(:initialize)” and run with -w, I’ll get:

“warning: undefining `initialize’ may cause serious problem”.

However, if don’t do that, I get “warning: method redefined;
discarding old initialize”.

Help! I’m trapped!

Thanks,

Dan


#2

On Apr 5, 2007, at 10:35 AM, Daniel B. wrote:

If I do “undef_method(:initialize)” and run with -w, I’ll get:

“warning: undefining `initialize’ may cause serious problem”.

Does this work?

remove_method(:initialize) if method_defined? :initialize

James Edward G. II


#3

Daniel B. wrote:

Hi all,

Is it possible to redefine initialize and stay -w clean? In win32-file-
stat, I’ve redefined initialize to suit my needs for MS Windows.

If I do “undef_method(:initialize)” and run with -w, I’ll get:

“warning: undefining `initialize’ may cause serious problem”.

However, if don’t do that, I get “warning: method redefined;
discarding old initialize”.

Try aliasing the method before redefining it:

alias :old_init :initialize
def initialize() end

regards,
andrew


#4

On Apr 5, 9:40 am, James Edward G. II removed_email_address@domain.invalid
wrote:

On Apr 5, 2007, at 10:35 AM, Daniel B. wrote:

If I do “undef_method(:initialize)” and run with -w, I’ll get:

“warning: undefining `initialize’ may cause serious problem”.

Does this work?

remove_method(:initialize) if method_defined? :initialize

Unfortunately, using remove_method just issues a different message:
“warning: removing `initialize’ may cause serious problem”

Regards,

Dan


#5

On Apr 5, 9:47 am, Andrew J. removed_email_address@domain.invalid wrote:

However, if don’t do that, I get “warning: method redefined;
discarding old initialize”.

Try aliasing the method before redefining it:

alias :old_init :initialize
def initialize() end

That doesn’t appear to work. Do you have a code snippet where it does
work? Perhaps I’ve missed something.

Thanks,

Dan


#6

On Apr 5, 2007, at 10:55 AM, Daniel B. wrote:

“warning: undefining `initialize’ may cause serious problem”.
work? Perhaps I’ve missed something.
Remove the colons or swap alias with alias_method and add a comma.

James Edward G. II


#7

Daniel B. wrote:

That doesn’t appear to work. Do you have a code snippet where it does
work? Perhaps I’ve missed something.

Perhaps I’ve misunderstood your case – the following runs -w clean on
Ruby 1.8.6

$ cat init.rb

class String
alias :old_init :initialize
def initialize() end
end

$ ruby -w init.rb
$

andrew


#8

On Apr 5, 2007, at 11:20 AM, Daniel B. wrote:

private. :slight_smile:
Can’t you safely remove it once it has been renamed?

James Edward G. II


#9

On Apr 5, 10:06 am, Andrew J. removed_email_address@domain.invalid wrote:

class String
alias :old_init :initialize
def initialize() end
end

Oh, I see. I had to remove the undef_method(:initialize) call with
this approach. Alright, this feels a bit clunky, but it will do the
job. The only thing I’m going to change is to making old_init
private. :slight_smile:

Many thanks,

Dan


#10

On Apr 5, 10:49 am, “Daniel B.” removed_email_address@domain.invalid wrote:

Daniel B. wrote:

Can’t you safely remove it once it has been renamed?

Looks that way. This ran -w clean for me:

class String
alias old_init initialize
def initialize
puts “hello”
end
remove_method(:old_init)
end

Quick followup. For singleton methods you MUST use the “class << self”
style for both the alias and the definition to avoid warnings:

This is -w clean

class File
class << self
alias :basename_orig :basename
def basename
puts “hello”
end
remove_method(:basename_orig)
end
end

This is not

class File
class << self
alias :basename_orig :basename
end

def self.basename
puts “hello”
end

class << self
remove_method(:basename_orig)
end
end

Regards,

Dan


#11

On Apr 5, 10:30 am, James Edward G. II removed_email_address@domain.invalid
wrote:

does
def initialize() end
end

Oh, I see. I had to remove the undef_method(:initialize) call with
this approach. Alright, this feels a bit clunky, but it will do the
job. The only thing I’m going to change is to making old_init
private. :slight_smile:

Can’t you safely remove it once it has been renamed?

Looks that way. This ran -w clean for me:

class String
alias old_init initialize
def initialize
puts “hello”
end
remove_method(:old_init)
end

Regards,

Dan