Re: Review: bugs


#1

Tomas suggested a different fix in Protocols.cs. I did a “git reset
-hard” to undo the previous commit and applied the new fix…

Thanks,
Shri

From: Shri B.
Sent: Thursday, May 07, 2009 10:06 AM
To: removed_email_address@domain.invalid; IronRuby External Code R.
Subject: Review: bugs

http://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4

“numeric + someOtherObj” should call
someOtherObj.method_missing(:coerce)
backtraces now include file names for builtin methods in
IronRuby.Libraries.dll in a DEBUG builds and with -X:ExceptionDetail
Enables RubyGems tests in irtests.bat

Files changed

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/bignum/plus_spec.rbhttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-0
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/fixnum/plus_spec.rbhttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-1
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/float/plus_spec.rbhttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-2
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/bigdecimal/plus_spec.rbhttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-3
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/BigDecimal/BigDecimalOps.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-4
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Numeric.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-5
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/ClrBigInteger.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-6
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/ClrFloat.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-7
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/ClrInteger.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-8
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-9
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/CallSiteStorages.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-10
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/Protocols.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-11
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyExceptionData.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-12
*
Merlin/Main/Languages/Ruby/Scripts/irtests.bathttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-13
Thanks,
Shri


#2

Looks good.

Tomas

From: Shri B.
Sent: Thursday, May 07, 2009 12:51 PM
To: removed_email_address@domain.invalid; IronRuby External Code R.
Subject: RE: Review: bugs

Tomas suggested a different fix in Protocols.cs. I did a “git reset
-hard” to undo the previous commit and applied the new fix…

http://github.com/shri/ironruby/commit/09b25e8c573464dc5868ab2521bd631a013527c7

Thanks,
Shri

From: Shri B.
Sent: Thursday, May 07, 2009 10:06 AM
To: removed_email_address@domain.invalid; IronRuby External Code R.
Subject: Review: bugs

http://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4

“numeric + someOtherObj” should call
someOtherObj.method_missing(:coerce)
backtraces now include file names for builtin methods in
IronRuby.Libraries.dll in a DEBUG builds and with -X:ExceptionDetail
Enables RubyGems tests in irtests.bat

Files changed

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/bignum/plus_spec.rbhttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-0
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/fixnum/plus_spec.rbhttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-1
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/float/plus_spec.rbhttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-2
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/bigdecimal/plus_spec.rbhttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-3
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/BigDecimal/BigDecimalOps.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-4
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Numeric.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-5
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/ClrBigInteger.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-6
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/ClrFloat.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-7
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/ClrInteger.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-8
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-9
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/CallSiteStorages.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-10
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/Protocols.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-11
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyExceptionData.cshttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-12
*
Merlin/Main/Languages/Ruby/Scripts/irtests.bathttp://github.com/shri/ironruby/commit/e83c916a3a0554ce9d0e394d1c97c19e6004afa4#diff-13
Thanks,
Shri