Re: Markdown + Smarty Pants

Ruby Apps Radiant CMS
1

Since Textile curls quotes automatically, my first thought is to just
add the SmartyPants functionality to the existing Markdown filter. Is
there a good reason not to do this? Should we ship a separate
SmartyPants filter as well?

Personally I always educate quotes. I submitted the patch as two
separate filters simply because Markdown and SmartyPants are (sort
of) distributed separately. I also figured it was nice to give people
the option of denying their quotes an education.

Having a standalone SmartyPants filter would be great, especially for
those who want to write HTML yet still educate their quotes. I’ll
submit a patch with tests if you like.

  • Sean
2

Having a standalone SmartyPants filter would be great, especially for
those who want to write HTML yet still educate their quotes. I’ll
submit a patch with tests if you like.

That sounds good.

http://dev.radiantcms.org:9007/radiant/ticket/362

  • Sean
3

Sean S. wrote:

Having a standalone SmartyPants filter would be great, especially for
those who want to write HTML yet still educate their quotes. I’ll
submit a patch with tests if you like.

That sounds good.

–
John L.
http://radiantcms.org

4

Sean S. wrote:

Having a standalone SmartyPants filter would be great, especially for
those who want to write HTML yet still educate their quotes. I’ll
submit a patch with tests if you like.
That sounds good.

http://dev.radiantcms.org:9007/radiant/ticket/362

Awesome. Bodhi, would you have a chance to look this over and apply it?

I looked at it briefly and it looked well implemented and tested.
Delicious! :slight_smile:

–
John L.
http://wiseheartdesign.com

5

On Sep 6, 2006, at 3:45 AM, Sean S. wrote:

The patch against r114 (with updated tests) is in

http://dev.radiantcms.org:9007/radiant/ticket/363

Great, saves me some work :slight_smile: I’ll check it out later today.

Bodhi

6

Awesome. Bodhi, would you have a chance to look this over and apply
it?

I looked at it briefly and it looked well implemented and tested.
Delicious! :slight_smile:

Now that the standalone SmartyPants filter is in r114 I’ve patched
the Markdown filter so it will educate quotes as well.

The patch against r114 (with updated tests) is in

http://dev.radiantcms.org:9007/radiant/ticket/363
  • Sean
7

Since Textile curls quotes automatically, my first thought is to just
add the SmartyPants functionality to the existing Markdown filter.

http://dev.radiantcms.org:9007/radiant/ticket/363

  • Sean