Re: gr_firdes.cc/firdes.cc - window functions - flawe

We installed gnuradio 3.6.3 using gnruadio build script. We can’t
change the gnuradio version currently. How can we apply this patch to
our installation. What commands should we run? We don’t use git.


Bob

On Mon, Oct 7, 2013 at 12:02 AM, bob wole [email protected] wrote:

We installed gnuradio 3.6.3 using gnruadio build script. We can’t change the
gnuradio version currently. How can we apply this patch to our installation.
What commands should we run? We don’t use git.


Bob

Hi Bob,

You’ll use the ‘patch’ command for this.

  1. Download the gnuradio-window-patch.diff from Chris’ post (into
    directory: ~/Downloads).
  2. cd into the GNU Radio source directory (I’ll assume the directory:
    ~/gnuradio-3.6.3)
  3. Run: ‘patch -p1 < ~/Downloads/gnuradio-window-patch.diff’

If it works, it will say:

patching file gnuradio-core/src/lib/general/gr_firdes.cc
patching file gr-filter/lib/firdes.cc

I just tried these steps on my own system using the 3.6.3 tarball from
our website.

However, I noticed that there is a problem with the patch in the
Kaiser window when the number of taps in the filter is odd. The patch
that I applied to maint/master/next (all 3.7) takes account of this
and works with both even and odd number of taps.

Also, many QA failures will occur with the patch because the Hilbert
transform assumed the use of a rectangular window. The results were
actually calculated using a Hamming window because of the bug, so
using the actual rectangular window will make the results different.
These are the QA failures I get with 3.6.3:

The following tests FAILED:
41 - qa_filter_delay_fc (Failed)
78 - qa_hilbert (Failed)
82 - qa_firdes (Failed)
92 - qa_filter_delay_fc (Failed)
101 - qa_hilbert (Failed)
Errors while running CTest

Again, the patch that I applied last week for 3.7 accounts for this
and fixes the QA code. I think it does so in a more elegant way, too,
and reduces many of our QA tests to comparing against a set of ‘gold’
results to actually properly calculating the results.

To summarize. The patch from Chris will be ok (though watch for a
Kaiser window with an odd number of taps) but will cause the QA to
fail. You can safely ignore that as it’s expected.

Tom

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs