Re: Code Review: math


#1

Doh, forgot the diff.

JD

From: Jim D.
Sent: Tuesday, October 14, 2008 2:49 PM
To: IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: Code Review: math

tfpt review “/shelveset:math;REDMOND\jdeville”

Comment :
Implements most of the missing math methods. Modifies specs around
those. Math.erf and Math.erfc are still unimplemented, and all Math
methods still don’t handle nil or coersion correctly.

JD
http://blog.jredville.com

#2

Looks good overall. You should probably resort the frexp, hypot and
ldexp methods back into alphabetical order.

From: Jim D.
Sent: Tuesday, October 14, 2008 2:50 PM
To: Jim D.; IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: RE: Code Review: math

Doh, forgot the diff.

JD

From: Jim D.
Sent: Tuesday, October 14, 2008 2:49 PM
To: IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: Code Review: math

tfpt review “/shelveset:math;REDMOND\jdeville”

Comment :
Implements most of the missing math methods. Modifies specs around
those. Math.erf and Math.erfc are still unimplemented, and all Math
methods still don’t handle nil or coersion correctly.

JD
http://blog.jredville.com