Re: Code Review: Fixes for File.dirname


#1

And now with the actual review link =P

http://github.com/jschementi/ironruby/commit/689aeec6046bc8ba76016f6dfa1bd947e8e3ce15

From: Jimmy S.
Sent: Sunday, April 12, 2009 12:56 AM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: Code Review: Fixes for File.dirname

Fixes for File.dirname; makes all core/file/dirname specs pass. For
Rails to find log/development.log during startup.

Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=499


#2

Looks good.

From: Jimmy S.
Sent: Sunday, April 12, 2009 12:59 AM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: RE: Code Review: Fixes for File.dirname

And now with the actual review link =P

http://github.com/jschementi/ironruby/commit/689aeec6046bc8ba76016f6dfa1bd947e8e3ce15

From: Jimmy S.
Sent: Sunday, April 12, 2009 12:56 AM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: Code Review: Fixes for File.dirname

Fixes for File.dirname; makes all core/file/dirname specs pass. For
Rails to find log/development.log during startup.

Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=499