Re: bug report: SSI -> signal 10 (nginx 0.7.10, Solaris 10)


#1

Yes Maxim,

your patch fixes the problem. But there remains an issue:
Errors on subrequests (e.g. 404) result in the inclusion of the error
pages in the main page.
I.e. in the body of the main page there starts a new html document
with the error message.

Regards
Hannes


#2

On Thu, Nov 06, 2008 at 01:50:22PM +0300, Maxim D. wrote:

But there remains an issue:
location /include/ {
error_page 404 /empty;

  •     error_page  404  /empty;
    
  •     error_page  404  = /empty;

#3

Hello!

On Thu, Nov 06, 2008 at 08:01:58AM +0100, Hannes Haug wrote:

Yes Maxim,

your patch fixes the problem.

Thanks for testing.

But there remains an issue:
Errors on subrequests (e.g. 404) result in the inclusion of the error
pages in the main page.
I.e. in the body of the main page there starts a new html document
with the error message.

It’s by design. Subrequests are just included into main page as
is, regardless of the error code. If you don’t want error replies
to be included you have to write in your config something like
this:

location /include/ {
    error_page  404  /empty;
}
location = /empty {
    return  204;
}

So if you use and
there is no “/include/file” - nginx will return empty page
instead, and no output will appear in main document.

See http://wiki.codemongers.com/NginxHttpCoreModule#error_page for
details.

Maxim D.


#4

On Thu, Nov 06, 2008 at 02:17:43PM +0300, Maxim D. wrote:

Yes Maxim,

It does it’s job in both cases, actually. From semantic point of
view ‘=’ may be better, but it shouldn’t influence real work
anyway. Or I missed something?

You are right.

BTW, did you picked alignment patch?

Yes, thank you.


#5

Hello!

On Thu, Nov 06, 2008 at 01:51:22PM +0300, Igor S. wrote:

Thanks for testing.
this:

location /include/ {
    error_page  404  /empty;
  •     error_page  404  /empty;
    
  •     error_page  404  = /empty;
    

It does it’s job in both cases, actually. From semantic point of
view ‘=’ may be better, but it shouldn’t influence real work
anyway. Or I missed something?

BTW, did you picked alignment patch?

Maxim D.