Please Break This: 0.5.1 RC1

Ruby Apps Radiant CMS
1

Just announced this on the blog:

http://radiantcms.org/blog/2006/08/03/please-break-this-radiant-0-5-1-rc1/

It?s been a bit quiet on the home front since the release of 0.5, but
that doesn?t mean that we haven?t been busy. Without further ado, I
present 0.5.1 release candidate 1:

http://radiantcms.org/downloads/radiant-0.5.1-rc1.gem

Why a release candidate? Mainly because this version included major
changes to the radiant command to allow users to upgrade existing
installs. I?d like for people to test it pretty thoroughly before we
release it into the wild.

To get started install the release candidate gem like this:

% gem install radiant-0.5.1-rc1.gem

Then cd to the directory where you have installed radiant and execute
this:

% radiant --upgrade .

Which should output something like this:

Upgrading Radiant to version 0.5.1…
Would you like to create backups of files that Radiant replaces?
[yN]n
overwrote ./CHANGELOG
overwrote ./CONTRIBUTORS
created ./public/.htaccess
created ./public/images/layout.png
overwrote ./public/images/new-layout.png
created ./script/console
created ./script/version
updated Rails version to 1.1.4 in config/environment.rb
updated Radiant version to 0.5.1 in config/instance.yml
Done.

Be sure to back up your install before upgrading. You can use the
radiant command to upgrade radiant applications that are running in
either instance mode or application mode.

Bug reports aren?t much good after an official release, so please: try
and break something!

Apart from upgrade support, this version of Radiant includes the
following enhancements:

  • The .htaccess file is now included in the public directory (this
    should make Apache users happy)

  • Migrations are now repaired so that you can run rake migrate to
    create the initial database. (However, script/setup_database is
    still the recommended method.) (closes ticket #46) [Daniel Shepherd]

  • When you collapse a branch in the admin page tree view and move to
    another tab the collapsed status is now saved so that when you
    return,
    the collapsed status is preserved. Also the status of collapsed
    branches is preserved when collapsing and expanding parent nodes.
    (closes ticket #29) [Daniel Shepherd]

A few additional patches may make it into this release, so please, if
you have a patch that you would like to see applied, speak up!

–
John L.
http://wiseheartdesign.com

2

On 03/08/2006, at 12:49 PM, John W. Long wrote:

Just announced this on the blog:

http://radiantcms.org/blog/2006/08/03/please-break-this-radiant-0-5-1-
rc1/

John, well done! once again, thanks for releasing radiant for us all!

Bug reports aren?t much good after an official release, so please: try
and break something!

The admin interface is still broken when you use option 1 (Empty) from
script/setup_database. I’ll file a ticket with a patch in a second,
just fixing it now.

Bodhi

3
  1. After upgradint to radiant 0.5.1. I got a “failed to update Rails
    version to 1.1.4 in config/environment.rb” message when updating an
    existing radiant instance. Is it harmful at all or just a warning?

electronicbusiness radiant # radiant --upgrade .
Upgrading Radiant to version 0.5.1…
Would you like to create backups of files that Radiant replaces? [yN]
y
overwrote ./CHANGELOG
backup CONTRIBUTORS? [Yn] y
backed up CONTRIBUTORS as CONTRIBUTORS.20060803.bak
overwrote ./CONTRIBUTORS
created ./public/.htaccess
created ./public/images/layout.png
backup public/images/new-layout.png? [Yn] y
backed up public/images/new-layout.png as new-layout.png.20060803.bak
overwrote ./public/images/new-layout.png
created ./script/console
created ./script/version

failed to update Rails version to 1.1.4 in config/environment.rb
you may need to do this yourself
updated Radiant version to 0.5.1 in config/instance.yml
Done.

  1. I issued again an update command on the same place I did before and
    I got the following “Cannot detect that Radiant is installed in this
    directory!” (below also an “ll” command of the instance directory):

electronicbusiness radiant # radiant --upgrade .
/usr/lib/ruby/gems/1.8/gems/radiant-0.5.1/bin/radiant:35: command not
found: ./script/version
Cannot detect that Radiant is installed in this directory!
electronicbusiness radiant # ll
total 52
drwxr-xr-x 5 root root 4096 Jul 12 20:49 cache
-rw-r–r-- 1 root root 641 Aug 3 12:03 CHANGELOG
drwxr-xr-x 3 root root 4096 Jun 26 23:12 config
-rw-r–r-- 1 root root 257 Aug 3 12:03 CONTRIBUTORS
-rw-r–r-- 1 root root 214 Aug 3 12:03 CONTRIBUTORS.20060803.bak
drwxr-xr-x 2 root root 4096 Jul 23 19:13 db
-rw-r–r-- 1 root root 1072 Jun 26 23:12 LICENSE
drwxr-xr-x 2 root root 4096 Jul 8 21:17 log
drwxr-xr-x 2 root root 4096 Jun 26 23:09 plugins
drwxr-xr-x 5 root root 4096 Aug 3 12:03 public
-rw-r–r-- 1 root root 2441 Jun 26 23:12 README
drwxr-xr-x 3 root root 4096 Aug 3 12:03 script
drwxr-xr-x 3 root root 4096 Jun 26 23:09 vendor

–M

4

On 3-Aug-06, at 1:53 AM | Aug 3, bodhi wrote:

The admin interface is still broken when you use option 1 (Empty) from
script/setup_database. I’ll file a ticket with a patch in a second,
just fixing it now.

An empty database doesn’t work for you even after applying the diff
from ticket 195? (Thanks for adding the test to that, by the way.)

James

5

On 03/08/2006, at 2:53 PM, bodhi wrote:

On 03/08/2006, at 12:49 PM, John W. Long wrote:

Bug reports aren?t much good after an official release, so please: try
and break something!

The admin interface is still broken when you use option 1 (Empty) from
script/setup_database. I’ll file a ticket with a patch in a second,
just fixing it now.

James MacAulay had already submitted a ticket/patch for it [1] so I
just added my patch there, his patch fixes the bug too, I just included
a test for it (and a fix as i found his patch after i made mine :slight_smile: ).

Bodhi

[1] http://dev.radiantcms.org/radiant/ticket/195

6

On 3-Aug-06, at 2:04 AM | Aug 3, bodhi wrote:

James MacAulay had already submitted a ticket/patch for it [1] so I
just added my patch there, his patch fixes the bug too, I just
included
a test for it (and a fix as i found his patch after i made mine :slight_smile: ).

Right, I was confused: I just noticed your test and didn’t notice the
other fix you made. I like your fix better anyway :slight_smile:

So is this issue because of today’s revision switching to Rails
1.1.4? Or has this bug been around since rev 84 and I haven’t noticed
it?

James

7

On 03/08/2006, at 3:20 PM, James MacAulay wrote:

So is this issue because of today’s revision switching to Rails
1.1.4? Or has this bug been around since rev 84 and I haven’t noticed
it?

I think this has been around since #84, as there are no other changes
on page_helper.rb since then…

Bodhi

8

Maurizio B. wrote:

  1. I issued again an update command on the same place I did before and
    I got the following “Cannot detect that Radiant is installed in this
    directory!” (below also an “ll” command of the instance directory):

electronicbusiness radiant # radiant --upgrade .
/usr/lib/ruby/gems/1.8/gems/radiant-0.5.1/bin/radiant:35: command not
found: ./script/version
Cannot detect that Radiant is installed in this directory!

Is ./script/version executable? This is probably the problem.

–
John L.
http://wiseheartdesign.com

9

Maurizio B. wrote:

overwrote ./CONTRIBUTORS
Done.
Please post your config/environment.rb. Radiant uses a simple regular
expression to substitute the gem version:

if file_sub(filename, /RAILS_GEM_VERSION\s*=\s*‘\d[.\d]+’/m,
“RAILS_GEM_VERSION = ‘#{version}’”)

See line 294 for the whole method:

http://dev.radiantcms.org/radiant/browser/trunk/radiant/bin/radiant#L294

  1. I issued again an update command on the same place I did before and
    I got the following “Cannot detect that Radiant is installed in this
    directory!” (below also an “ll” command of the instance directory):

Mmmm. I’ll look into this.

–
John L.
http://wiseheartdesign.com

10

On 03/08/2006, at 12:49 PM, John W. Long wrote:

Bug reports aren?t much good after an official release, so please: try
and break something!

In development mode, radiant.rb is reloaded everytime:

192.168.1.21 - [Fri, 04 Aug 2006 03:09:08 GMT] “POST
/admin/ui/pages/children/1 HTTP/1.1”
/Sites/radiant-patch/config/…/lib/radiant.rb:5: warning: already
initialized constant Major
/Sites/radiant-patch/config/…/lib/radiant.rb:6: warning: already
initialized constant Minor
/Sites/radiant-patch/config/…/lib/radiant.rb:7: warning: already
initialized constant Tiny
192.168.1.21 - [Fri, 04 Aug 2006 03:09:12 GMT] “GET /admin/pages
HTTP/1.1”
/Sites/radiant-patch/config/…/lib/radiant.rb:5: warning: already
initialized constant Major
/Sites/radiant-patch/config/…/lib/radiant.rb:6: warning: already
initialized constant Minor
/Sites/radiant-patch/config/…/lib/radiant.rb:7: warning: already
initialized constant Tiny

Not a big problem, but it is a bit annoying :slight_smile:

Bodhi

11

bodhi wrote:

The admin interface is still broken when you use option 1 (Empty) from
script/setup_database. I’ll file a ticket with a patch in a second,
just fixing it now.

James MacAulay had already submitted a ticket/patch for it [1] so I
just added my patch there, his patch fixes the bug too, I just included
a test for it (and a fix as i found his patch after i made mine :slight_smile: ).

This is now fixed:

http://dev.radiantcms.org/radiant/ticket/195

Thanks guys!

–
John L.
http://wiseheartdesign.com

12

bodhi wrote:

On 03/08/2006, at 12:49 PM, John W. Long wrote:

Bug reports aren?t much good after an official release, so please: try
and break something!

In development mode, radiant.rb is reloaded everytime: …

Just committed a fix for this:

http://dev.radiantcms.org/radiant/changeset/94

–
John L.
http://wiseheartdesign.com

13

What work would it take, from me, to get the sort and re parent
included in 5.1?

14

Erik B. Ordway wrote:

What work would it take, from me, to get the sort and re parent
included in 5.1?

Mainly I need to have the time to review the patch. You and Bodhi have
both been working on this. Which one is the proper patch?

–
John L.
http://wiseheartdesign.com

15

On 09/08/2006, at 12:49 PM, John W. Long wrote:

Erik B. Ordway wrote:

What work would it take, from me, to get the sort and re parent
included in 5.1?

Mainly I need to have the time to review the patch. You and Bodhi have
both been working on this. Which one is the proper patch?

I haven’t kept up with Erik’s work, but I do know that my patch breaks
the css layout on the snippets and layouts lists.

Bodhi

16

I’ll take a look but bodhi’s interface changes even if there are
fixes needed for snippets and layout (although I am using it and see
no issues) is the way to go for the sorting of children in a parent.
I have added on to his work to add re-parenting up and down and
posted that as an enhanced version of his patch. It is much less
invasive than my orignal patch and with his change to lists and spans
much cleaner.

17

bodhi wrote:

What work would it take, from me, to get the sort and re parent
included in 5.1?

Mainly I need to have the time to review the patch. You and Bodhi have
both been working on this. Which one is the proper patch?

I haven’t kept up with Erik’s work, but I do know that my patch breaks
the css layout on the snippets and layouts lists.

Ok, I’ll need a complete patch before I can consider it for inclusion in
the core. Also, briefly looking over your patch, there were some changes
made last night that probably make your patch incompatible with whats in
trunk. If you can make sure that your patch is ready to go it will
certainly make things easier if I get to the point of being ready to
apply it.

–
John L.
http://wiseheartdesign.com