[patch] Ensure correct refcounting on Gst::ElementFactory.make

Desktop Ruby-Gnome 2
1

Hi,

See patch for details. I was unsure which coding-style to use here. I
picked
the one already used in this file to minimize white-space diffs and
prevent
coding style inconsitency inside one function.

Sjoerd

2

Hi,

In [email protected]
“[ruby-gnome2-devel-en] [patch] Ensure correct refcounting on
Gst::ElementFactory.make” on Sat, 29 Mar 2008 17:55:39 +0100,
Sjoerd S. [email protected] wrote:

See patch for details. I was unsure which coding-style to use here. I picked
the one already used in this file to minimize white-space diffs and prevent
coding style inconsitency inside one function.

Use GOBJ2RVAL_UNREF() for this.

Please fix coding-style after fix the problem.

Thanks,

kou

3

On Sun, Mar 30, 2008 at 08:31:07AM +0900, Kouhei S. wrote:

Use GOBJ2RVAL_UNREF() for this.

Please fix coding-style after fix the problem.

Committed with that changed and the function in hopefully fixed
coding-style :slight_smile:

Sjoerd

What is now proved was once only imagin’d.
– William Blake

4

Hi,

In [email protected]
“Re: [ruby-gnome2-devel-en] [patch] Ensure correct refcounting on
Gst::ElementFactory.make” on Sat, 5 Apr 2008 18:39:18 +0200,
Sjoerd S. [email protected] wrote:

On Sun, Mar 30, 2008 at 08:31:07AM +0900, Kouhei S. wrote:

Use GOBJ2RVAL_UNREF() for this.

Please fix coding-style after fix the problem.

Committed with that changed and the function in hopefully fixed coding-style :slight_smile:

I’ve fixed coding-style. Please confirm that and commit all
your reviewed patches. You don’t need to care coding-style
at present. I’ll fix. It seems that Ruby/GStreamer blocks
Joachim’s work.

Thanks,

kou