Page caching feed urls

When I look at my Server stats, the top 10 pages are feeds. Feeds
don’t change very much, and none of the feed urls we publish have
query strings. So, I went to xml_controller.rb and replaced the line
that reads

caches_action_with_params :feed

with a line that reads

caches_page :feed

So far, nothing bad happening, the page cache gets swept correctly the
load on my dispatch.fcgi is drastically reduced. I commend the change
to you all.

However, I’m holding off making it an official patch for the time
being because you need to check your circumstances are okay. Check
your server logs for /xml/whatever?somearg=someval type requests
before you proceed. If you do find any, and they’re frequent enough
that you can’t ignore them, don’t make the switch.

Some feedback here on people’s experiences in this regard would be
good.

I made the change. No issues. Nothing broken, feeds still up and
running…

On 24/08/2006, at 2:46 AM, Piers C. wrote:

Some feedback here on people’s experiences in this regard would be
good.

Works for me.

I initially thought it was going to enable client-side caching - ie
returning HTTP code 304 not modified instead of the entire feed - but
then I realised you were talking about the server cache.

Just out of interest: does anyone else get feed caching on the client
side? Maybe it’s something wrong with my setup. I’m using an Apache
proxy to mongrel, if it matters. Using NetNewsWire’s Bandwidth Stats
window to test.