Object Service instance

musicdenotation · March 31, 2015, 6:18am

Hi (I am a beginner)

I have a project that add users, profiles, etc.
I genetered it using scaffold. It’s everything ok up here.
I need to do the crud operations in a service class and not in the
controllers.

I created a services folder into App folder and create a UserService.rb
class .

So the idea is that the controller call to UserService class , and the
userService Class do the crud(create, read, update, delete) operation.

But I got this error message : uninitialized constant
UsersController::UserService .

I tried add a instance to routes.rb , also to application.rb but the
error is still there.

I have searched many examples and tried many things, but can not find
solution.

Any suggestions?
PD: Sorry for my English

jhonnatanmc · March 31, 2015, 10:05am

On 31 March 2015 at 05:18, Jhonnatan Mc [email protected] wrote:

Hi (I am a beginner)

I have a project that add users, profiles, etc.
I genetered it using scaffold. It’s everything ok up here.
I need to do the crud operations in a service class and not in the
controllers.

Why?

Colin

jhonnatanmc · March 31, 2015, 3:13pm

I don’t know.

I’am trying to do this:

#App/Controller/user_controller
def create
@user = UserService.create(params[:user_params])
end

#App/services/UserService.rb

class UserService

def self.create(user_params)

 @user = User.new(user_params)

end
end

I got this error message:
uninitialized constant UsersController::UserService

@user = UserService.create(params[:user_params])

jhonnatanmc · March 31, 2015, 4:08pm

On Tue, Mar 31, 2015 at 8:13 AM, Jhonnatan Mc [email protected]
wrote:

^^ If this is the actual name of the file, then Rails autoloading will
not work on it. When Rails encounters a class called “UserService” it
looks
through the autoload paths for a file entitled: “user_service.rb” (i.e.
snake case, not CamelCase).

jhonnatanmc · March 31, 2015, 9:21pm

I tried that.
this is the project:

jhonnatanmc · March 31, 2015, 10:26pm

On 31 March 2015 at 20:21, Jhonnatan Mc [email protected] wrote:

I tried that.
this is the project:

You tried what? You have not quoted the previous message so we don’t
know what you are referring to.

Object_Service_RoR/prueba at master · JhonnatanMc/Object_Service_RoR · GitHub

Look at the name of the class (UserService). Now look at the name of
the file. Now look again if necessary. Keep looking…

Colin

jhonnatanmc · March 31, 2015, 10:44pm

On 31 March 2015 at 21:32, Jhonnatan Mc [email protected] wrote:

Look at the name of the class (UserService). Now look at the name of
the file. Now look again if necessary. Keep looking…

Colin

I tried changed the name of el file from UserService to user_service.
the class name is UserService.

Correct the code in your repo then copy/paste here the error you get
with the correct name.

Colin

jhonnatanmc · March 31, 2015, 10:32pm

Colin L. wrote in post #1171239:

On 31 March 2015 at 20:21, Jhonnatan Mc [email protected] wrote:

I tried that.
this is the project:

You tried what? You have not quoted the previous message so we don’t
know what you are referring to.

Object_Service_RoR/prueba at master · JhonnatanMc/Object_Service_RoR · GitHub

Look at the name of the class (UserService). Now look at the name of
the file. Now look again if necessary. Keep looking…

Colin

I tried changed the name of el file from UserService to user_service.
the class name is UserService.

In the controller I have the followings:
user = UserService.create(params[:user_params])

jhonnatanmc · April 1, 2015, 9:28am

On 31 March 2015 at 22:16, Jhonnatan Mc [email protected] wrote:

Correct the code in your repo then copy/paste here the error you get
with the correct name.

The code is still wrong in the repo. As I said, correct the code in
the repo, make sure that is the code you are running, and try again.
It is difficult to help if you do not do what is asked.

Colin

jhonnatanmc · April 1, 2015, 4:11pm

On Mar 31, 2015, at 7:13 AM, Jhonnatan Mc [email protected] wrote:

@user = User.new(user_params)

end
end

Going back a few posts: there’s a pretty obvious error there, if that’s
your actual code…

jhonnatanmc · March 31, 2015, 11:16pm

Colin L. wrote in post #1171241:

On 31 March 2015 at 21:32, Jhonnatan Mc [email protected] wrote:

Look at the name of the class (UserService). Now look at the name of
the file. Now look again if necessary. Keep looking…

Colin

I tried changed the name of el file from UserService to user_service.
the class name is UserService.

Correct the code in your repo then copy/paste here the error you get
with the correct name.

Colin

NameError in UsersController#create
uninitialized constant UsersController::UserService

jhonnatanmc · April 1, 2015, 3:56pm

Colin L. wrote in post #1171272:

On 31 March 2015 at 22:16, Jhonnatan Mc [email protected] wrote:

Correct the code in your repo then copy/paste here the error you get
with the correct name.

The code is still wrong in the repo. As I said, correct the code in
the repo, make sure that is the code you are running, and try again.
It is difficult to help if you do not do what is asked.

Colin

I corrected the code in the repo. The file name is user_service.rb and
the class name is : UserService.
I got this error message:
uninitialized constant UsersController::UserService

jhonnatanmc · April 1, 2015, 4:20pm

On 1 April 2015 at 14:56, Jhonnatan Mc [email protected] wrote:

Colin

I corrected the code in the repo. The file name is user_service.rb and
the class name is : UserService.

That is not what this says the file name is

It says it is “Class user_service.rb”

Colin

jhonnatanmc · April 1, 2015, 4:39pm

You’ll also need to make sure app/services is in autoload_paths in
application.rb

github.com

JhonnatanMc/Object_Service_RoR/blob/master/prueba/config/application.rb#L14


      
          
          
# Require the gems listed in Gemfile, including any gems
          # you've limited to :test, :development, or :production.
          Bundler.require(*Rails.groups)
          
          

          
module TestApp
            class Application < Rails::Application
              
              
              config.autoload_paths += %W( #{config.root}/app/services)
              # Settings in config/environments/* take precedence over those specified here.
              # Application configuration should go into files in config/initializers
              # -- all .rb files in that directory are automatically loaded.
          
          
    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
              # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
              # config.time_zone = 'Central Time (US & Canada)'
          
          
    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
              # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]

jhonnatanmc · April 1, 2015, 4:53pm

Brad P. wrote in post #1171299:

You’ll also need to make sure app/services is in autoload_paths in
application.rb

github.com

JhonnatanMc/Object_Service_RoR/blob/master/prueba/config/application.rb#L14


      
          
          
# Require the gems listed in Gemfile, including any gems
          # you've limited to :test, :development, or :production.
          Bundler.require(*Rails.groups)
          
          

          
module TestApp
            class Application < Rails::Application
              
              
              config.autoload_paths += %W( #{config.root}/app/services)
              # Settings in config/environments/* take precedence over those specified here.
              # Application configuration should go into files in config/initializers
              # -- all .rb files in that directory are automatically loaded.
          
          
    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
              # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
              # config.time_zone = 'Central Time (US & Canada)'
          
          
    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
              # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]

In application.rb I wrote this line:

config.autoload_paths += %W( #{config.root}/app/services )

jhonnatanmc · April 1, 2015, 4:55pm

Colin L. wrote in post #1171296:

On 1 April 2015 at 14:56, Jhonnatan Mc [email protected] wrote:

Colin

I corrected the code in the repo. The file name is user_service.rb and
the class name is : UserService.

That is not what this says the file name is

It says it is “Class user_service.rb”

Colin

I corrected the name:

#App/Controller/user_controller
def create
@user = UserService.create(user_params)
end

#App/services/user_service.rb

class UserService

def self.create(user_params)

 @user = User.new(user_params)
   ...

end
end

I understood that if the class name is UserSerice the file name must be
user_service.rb, isn’t it ?

jhonnatanmc · April 1, 2015, 5:26pm

On 1 April 2015 at 15:55, Jhonnatan Mc [email protected] wrote:

It says it is “Class user_service.rb”

Colin

I corrected the name:

I am glad it is all working at last.

Colin

jhonnatanmc · April 1, 2015, 5:56pm

On 1 April 2015 at 16:47, Jhonnatan Mc [email protected] wrote:

Colin

Not yet.
I got the same error message:
uninitialized constant UsersController::UserService

Copy/paste the rails log from start of the request showing the
complete error message and stack if any please.

Colin

jhonnatanmc · April 1, 2015, 5:57pm

Colin L. wrote in post #1171306:

On 1 April 2015 at 15:55, Jhonnatan Mc [email protected] wrote:

It says it is “Class user_service.rb”

Colin

I corrected the name:

I am glad it is all working at last.

Colin

This is working!
Thanks you so much!

jhonnatanmc · April 1, 2015, 5:47pm

Colin L. wrote in post #1171306:

On 1 April 2015 at 15:55, Jhonnatan Mc [email protected] wrote:

It says it is “Class user_service.rb”

Colin

I corrected the name:

I am glad it is all working at last.

Colin

Not yet.
I got the same error message:
uninitialized constant UsersController::UserService.

in this line:
user = UserService.create(user_params)