More string encodings

the attached patch fixes more string encodings in places currently
using rb_str_new* or StringValuePtr.

i have reviewed glib2, pango, gdkpixbuf and gtk2. i know too little
other modules to review them for the same thing, sorry.

please review?

Hi,

In [email protected]
“[ruby-gnome2-devel-en] more string encodings” on Thu, 7 Oct 2010
22:57:05 +0200,
Guillaume C. [email protected] wrote:

the attached patch fixes more string encodings in places currently
using rb_str_new* or StringValuePtr.

i have reviewed glib2, pango, gdkpixbuf and gtk2. i know too little
other modules to review them for the same thing, sorry.

please review?

It seems good to me.
Please commit it!

Thanks,

kou

On 9 October 2010 06:16, Guillaume C. [email protected]
wrote:

Now, do you know what else needs to be done to support Ruby 1.9
Strings in rg2? As for me, my “booh” application seems to work
properly now.

By the way, thank you for doing all this!!! Probably with this I’ll be
able
to move my app over to 1.9 (if I can find time!) It’s something I have
wanted to do for a long time. I really appreciate it :slight_smile:

    MikeC

please review?

It seems good to me.
Please commit it!

Done.

Now, do you know what else needs to be done to support Ruby 1.9
Strings in rg2? As for me, my “booh” application seems to work
properly now.

Thanks,


Guillaume C. - http://zarb.org/~gc/

On Sat, Oct 9, 2010 at 12:24 AM, Mike C. [email protected]
wrote:

On 9 October 2010 06:16, Guillaume C. [email protected] wrote:

Now, do you know what else needs to be done to support Ruby 1.9
Strings in rg2? As for me, my “booh” application seems to work
properly now.

By the way, thank you for doing all this!!! Probably with this I’ll be able
to move my app over to 1.9 (if I can find time!) It’s something I have
wanted to do for a long time. I really appreciate it :slight_smile:

You’re welcome. I wanted to ask others to test their app with rg2-svn
and ruby 1.9, so that we know if there are more things to do before
officially pretending rg2 is ruby 1.9 compatible. So please test with
rg2-svn and report back!

Thanks,


Guillaume C. - http://zarb.org/~gc/

On 10 October 2010 00:14, Guillaume C. [email protected]
wrote:

So please test with
rg2-svn and report back!

I will definitely do so. I actually have some 1.9 encoding issues
of my own to tackle, though. It might take me a while :slight_smile:
I’ll try to get back to you tomorrow.

      MikeC

On Sun, Oct 10, 2010 at 2:11 AM, Mike C. [email protected]
wrote:

On 10 October 2010 00:14, Guillaume C. [email protected] wrote:

So please test with
rg2-svn and report back!

I will definitely do so. I actually have some 1.9 encoding issues
of my own to tackle, though. It might take me a while :slight_smile:

do you have C code? otherwise, pure ruby code should be easily
“ported” to 1.9 with encodings? do you want to share what’s the
problems?


Guillaume C. - http://zarb.org/~gc/

On 11 October 2010 05:46, Guillaume C. [email protected]
wrote:

do you have C code? otherwise, pure ruby code should be easily
“ported” to 1.9 with encodings? do you want to share what’s the
problems?

No it’s ruby code, but I read in files of many different encodings
and specifically detect and modify the encodings of the strings.
All that stuff has changed. It’s not difficult, but I just have to
find time to do it :slight_smile: My programming time is limited to only
a few hours a week unfortunately…

   MikeC

2010/10/9 Guillaume C. [email protected]:

You’re welcome. I wanted to ask others to test their app with rg2-svn
and ruby 1.9, so that we know if there are more things to do before
officially pretending rg2 is ruby 1.9 compatible. So please test with
rg2-svn and report back!

Thanks,

I have test ZiK with ruby 1.9.1. Everything seems all rigth except for
a segmentation fault when I close the application.
See reported bug :
http://sourceforge.net/tracker/?func=detail&aid=3046538&group_id=53614&atid=470969
.
Mor info on http://redmine.ruby-lang.org/issues/show/319 .

P.S. : Maybe we should move this conversation to a new one.


Vincent C.

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs