Make distcheck fails

GNU Radio
#1

make distcheck
fails cause it cannot find the file
/gnuradio_svn/gr-trellis/src/python/awgn1o2_4.fsm
inside the directory
/gnuradio_svn/gnuradio-2.8svn/gr-trellis/src/python
so one of the qa_ checks fails.

How should I modify
/gnuradio_svn/gr-trellis/src/python/Makefile.am
to make sure that the awgn1o2_4.fsm file
ends up in the distribution directory?

Thanks
Achilleas

/gnuradio_svn/gr-trellis/src/python/Makefile.am

include $(top_srcdir)/Makefile.common

EXTRA_DIST = run_tests.in

TESTS =
run_tests

noinst_PYTHON =
qa_trellis.py

#2

On Fri, August 11, 2006 10:42, Achilleas A. wrote:

How should I modify
/gnuradio_svn/gr-trellis/src/python/Makefile.am
to make sure that the awgn1o2_4.fsm file
ends up in the distribution directory?

Add ‘awgn1o2_4.fsm’ to then end of the EXTRA_DIST line in
gr-trellis/src/python/Makefile.am.

-Johnathan

#3

OK fixed this and committed the change to trunk so now
make distcheck
succeeds.
From now on I will be working on my branch tree.

Thanks
Achilleas

#4

On Fri, Aug 11, 2006 at 01:42:39PM -0400, Achilleas A.
wrote:

to make sure that the awgn1o2_4.fsm file
ends up in the distribution directory?

Thanks
Achilleas

Try adding it to EXTRA_DIST

Eric

#5

Achilleas A. wrote:

  1. make sure that awgn1o2.fsm is copied form
    gnuradio-2.8svn/gr-trellis/src/python
    to
    _build/gr-trellis/src/python

  2. make sure that inside qa_trellis.py, the reference to
    the file “awgn1o2.py” is done in a way that it always
    ensures it will get it from
    /home/anastas/gnuradio_svn/gnuradio-2.8svn/gr-trellis/src/python

Choice 2 is the best way.

At build time, there is a shell variable set to the top source
directory. So you can export an environment variable:

export SRCDIR=$(top_srcdir)/gr-trellis/src/python

…in the run_tests.in before the loop that invokes the qa files.

Then in qa_trellis.py, import the os module:

import os

and reference

os.environ[‘SRCDIR’] to get the directory where the .fsm files are.

It’s ugly and hackish, I know.

-Johnathan

#6

I did this:
make check
runs fine
BUT
make distcheck
still fails.

I guess the reason is that it executes:

/home/anastas/gnuradio_svn/gnuradio-2.8svn/_build/gr-trellis/src/python/qa_trellis.py

from the “_build” directory, while
the required file “awgn1o2.fsm” is in

/home/anastas/gnuradio_svn/gnuradio-2.8svn/gr-trellis/src/python

There are 2 ways to fix this:

  1. make sure that awgn1o2.fsm is copied form
    gnuradio-2.8svn/gr-trellis/src/python
    to
    _build/gr-trellis/src/python

  2. make sure that inside qa_trellis.py, the reference to
    the file “awgn1o2.py” is done in a way that it always
    ensures it will get it from
    /home/anastas/gnuradio_svn/gnuradio-2.8svn/gr-trellis/src/python

How can I achieve either of these?
Achilleas

#7

Johnathan C. wrote:

export SRCDIR=$(top_srcdir)/gr-trellis/src/python

This should be:

export [email protected][email protected]/gr-trellis/src/python

…for the run_tests.in file.

-Johnathan