Make check errors

GNU Radio
1

I finally got around to updating to the new top-block code, and ‘make
check’ now fails on both Intel-Mac and PPC-Mac running OSX 10.4.11.
The QA code is fine. Anyone else see this issue? - MLD

Making check in gnuradio-core
Making check in src
Making check in python
Making check in gnuradio
Making check in gr

FAIL: test_iir_direct_003 (main.test_iir)

Traceback (most recent call last):
File “./qa_iir.py”, line 73, in test_iir_direct_003
self.assertFloatTuplesAlmostEqual (expected_result, result_data)
File “/GNURadio/trunk_2.4/gnuradio-core/src/python/gnuradio/
gr_unittest.py”, line 86, in assertFloatTuplesAlmostEqual
self.assertAlmostEqual (a[i], b[i], places, msg)
AssertionError: 15 != 4.0 within 7 places

======================================================================
FAIL: test_iir_direct_004 (main.test_iir)

Traceback (most recent call last):
File “./qa_iir.py”, line 87, in test_iir_direct_004
self.assertFloatTuplesAlmostEqual (expected_result, result_data)
File “/GNURadio/trunk_2.4/gnuradio-core/src/python/gnuradio/
gr_unittest.py”, line 86, in assertFloatTuplesAlmostEqual
self.assertAlmostEqual (a[i], b[i], places, msg)
AssertionError: 13 != 4.0 within 7 places

======================================================================
FAIL: test_iir_direct_005 (main.test_iir)

Traceback (most recent call last):
File “./qa_iir.py”, line 101, in test_iir_direct_005
self.assertFloatTuplesAlmostEqual (expected_result, result_data)
File “/GNURadio/trunk_2.4/gnuradio-core/src/python/gnuradio/
gr_unittest.py”, line 86, in assertFloatTuplesAlmostEqual
self.assertAlmostEqual (a[i], b[i], places, msg)
AssertionError: 13 != 4.0 within 7 places

======================================================================
FAIL: test_iir_direct_006 (main.test_iir)

Traceback (most recent call last):
File “./qa_iir.py”, line 118, in test_iir_direct_006
self.assertFloatTuplesAlmostEqual (expected_result, result_data)
File “/GNURadio/trunk_2.4/gnuradio-core/src/python/gnuradio/
gr_unittest.py”, line 86, in assertFloatTuplesAlmostEqual
self.assertAlmostEqual (a[i], b[i], places, msg)
AssertionError: 13 != 4.0 within 7 places

======================================================================
FAIL: test_iir_direct_007 (main.test_iir)

Traceback (most recent call last):
File “./qa_iir.py”, line 135, in test_iir_direct_007
self.assertFloatTuplesAlmostEqual (expected_result, result_data)
File “/GNURadio/trunk_2.4/gnuradio-core/src/python/gnuradio/
gr_unittest.py”, line 86, in assertFloatTuplesAlmostEqual
self.assertAlmostEqual (a[i], b[i], places, msg)
AssertionError: 2 != 4.0 within 7 places

======================================================================
FAIL: test_iir_direct_008 (main.test_iir)

Traceback (most recent call last):
File “./qa_iir.py”, line 152, in test_iir_direct_008
self.assertFloatTuplesAlmostEqual (expected_result, result_data)
File “/GNURadio/trunk_2.4/gnuradio-core/src/python/gnuradio/
gr_unittest.py”, line 86, in assertFloatTuplesAlmostEqual
self.assertAlmostEqual (a[i], b[i], places, msg)
AssertionError: 4 != 6.0 within 7 places

2

Michael D. wrote:

I finally got around to updating to the new top-block code, and ‘make
check’ now fails on both Intel-Mac and PPC-Mac running OSX 10.4.11. The
QA code is fine. Anyone else see this issue? - MLD

I see this as well now. It can be attributed to a check-in on the trunk
2 days ago that Martin did to fix an iir bug (r7089). I suspect the iir
QA needs to be updated.

–
Johnathan C.
Corgan Enterprises LLC
http://corganenterprises.com

3

On 12/11/07, Johnathan C. [email protected] wrote:

I see this as well now. It can be attributed to a check-in on the trunk
2 days ago that Martin did to fix an iir bug (r7089). I suspect the iir
QA needs to be updated.

The changeset for r7089 has been reverted on the trunk.

–
Johnathan C.
Corgan Enterprises LLC
http://corganenterprises.com/

4

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Johnathan C. wrote:

On 12/11/07, Johnathan C. [email protected] wrote:

I see this as well now. It can be attributed to a check-in on the trunk
2 days ago that Martin did to fix an iir bug (r7089). I suspect the iir
QA needs to be updated.

The changeset for r7089 has been reverted on the trunk.

I looked through that code and the formulas in the header file and did
the QA by hand and it seems that the reverted version is/was correct.
Perhaps there was an error forgetting to prepend a 0 into the fb_taps
that made someone think there was a bug?

  • -Dan
    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.6 (GNU/Linux)
    Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHX2CZy9GYuuMoUJ4RAjKgAJ4l5cQ6B8vJUqyEbuMvZhfoQZRbSQCdFJTG
QiFBO/PjvRX1y96QvGT43Vs=
=x9HD
-----END PGP SIGNATURE-----