Loop in rails view

Rails
1

controller
@update_coupon = JSON.parse(get_updatecpn.body)
*
*
view
1, <% @update_coupon.each do |doc| %>
2, <% if doc[“value”] == 2 %>

3, <%end%>

Here the @update_coupon getting from controller,In the controller i
got
all the value from @update_coupon so i need to take the value from
this*
@update_coupon* in view. so when i am trying to take the value from
the @update_coupon, it gives an error can’t convert string to integer
in
line 2

have any other way to do this view?

2

I don’t know if is the best solution but try a cast with to_i in
doc[“value”].

doc[“value”] .to_i

On Tue, May 22, 2012 at 10:29 AM, amvis [email protected] wrote:

Here the @update_coupon getting from controller,In the controller i got
You received this message because you are subscribed to the Google G.
“Ruby on Rails: Talk” group.
To view this discussion on the web visit
https://groups.google.com/d/msg/rubyonrails-talk/-/xnmAl4-br4IJ.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en.

–
Atenciosamente,
Guilherme Pereira Dutra,
Fone: (34) 8407-0109

3

Also, you could clean things a little by doing:

<% @update_coupon.select{|doc| doc[“value”] == 2}.each do |doc| %>
do stuff
<% end %>

On Tue, May 22, 2012 at 7:02 PM, Guilherme Dutra
[email protected]wrote:

from the @update_coupon, it gives an error *can’t convert string to
https://groups.google.com/d/msg/rubyonrails-talk/-/xnmAl4-br4IJ.
Atenciosamente,
http://groups.google.com/group/rubyonrails-talk?hl=en.

–

  • Aziz M. Bookwala

Website http://azizmb.in/ | Twitter https://twitter.com/azizbookwala
|
Github http://github.com/azizmb

4

El martes, 22 de mayo de 2012 15:29:04 UTC+2, amvis escribi:

Here the @update_coupon getting from controller,In the controller i got
all the value from @update_coupon so i need to take the value from this*
@update_coupon* in view. so when i am trying to take the value from
the @update_coupon, it gives an error can’t convert string to integer in
line 2

have any other way to do this view?

Your condition should be one of these:

  • doc[“value”] == “2” / doc[“value”].eql?(“2”)
  • doc[“value”].to_i == 2 / doc[“value”].to_i.eql?(2)

Alternatively you might as well iterate through already selected items:

@update_coupon.select{ |q| q["value].eql?(‘2’) }each do |doc|
…

There are lots of ways of doing this to find your favourite.

5

El martes, 22 de mayo de 2012 15:56:54 UTC+2, amvis escribi:

  <%elsif  doc["value"] == 6 %>

controller
got all the value from @update_coupon so i need to take the value
Groups “Ruby on Rails: Talk” group.

[email protected].
| Github http://github.com/azizmb

What are you trying to achieve with that, exactly? Looks like grouping
to
me, in which case you might do in your controller:

@update_coupon = @update_coupon.group_by(&:value)

Assuming @update_coupon is an array of a class having a value attribute,
that would return a hash much alike:
{
2 => [UC1, UC2…],
5 => [UC3, UC4…],
…
}

Once in your view you might iterate as follows:

@update_coupon.each do |key, val|
  //code related to key, such as: 
<%= key%>

  val.each do |update_coupon|
    // code related to each update_coupon
  end
end
6

On Tuesday, 22 May 2012 09:34:20 UTC-4, azizmb.in wrote:

Also, you could clean things a little by doing:

<% @update_coupon.select{|doc| doc[“value”] == 2}.each do |doc| %>
do stuff
<% end %>

Thanks all
  i think the above one is working, but i am confused with other

problem, here in my code

<% @update_coupon.each do |doc| %>
<% if doc[“value”] == 2 %>
//code
<%elsif doc[“value”] == 5 %>
//code
<%elsif doc[“value”] == 6 %>
//code
<%end%>

<%end%>

so how to integrate with this @update_coupon.select{|doc| doc[“value”]

2}.each do |doc| …?

7

On Tuesday, 22 May 2012 10:23:53 UTC-4, Juan P. Avello wrote:

  <% if  doc["value"] == 2 %>

2}.each do |doc| …?

doc[“value”] .to_i

2, <% if doc[“value”] == 2 %>

[email protected].

@update_coupon = @update_coupon.group_by(&:value)

basically with that if condition, i need to show different div,

<% @update_coupon.each do |doc| %>
<% if doc[“value”] == 2 %>
//code
<%elsif doc[“value”] == 5 %>
//code
<%elsif doc[“value”] == 6 %>
//code
<%end%>

<%end%>

8

On 22 May 2012 15:36, amvis [email protected] wrote:

<%end%>

You need a “case” statement as a starting point:

9

On 22 May 2012 15:36, amvis [email protected] wrote:

On Tuesday, 22 May 2012 09:34:20 UTC-4, azizmb.in wrote:
problem, here in my code
<%end%>

You also want to be using a helper method here, maybe rendering a
different
partial depending on the value. When you start seeing this much logic in
your view code, it’s probably wise to look at helpers and partials.

10

I would still iterate the elements that way, then you may extract the
div
construction to several partials or a helper receiving the key and value
that deals with what to render on each case.

It may sound a bit complex, but this way you keep your views clean,
which
are 90% of the times the dirtiest part of an app by far, and future
changes
are faster to perform if you reuse that code somewhere else