Is git commit access open to everyone?

GNU Radio
1

Hi,
I was quite surprised when I had commit access to the master
branch. Isn’t that a bit too open, or uncontrolled? :slight_smile: Not that I’m
complaining, but mistakes can happen, and the worst kind of mistake is
if someone does a forced update from their local branch to the git
master branch, thereby over-writing all changes on the master branch.

The following patch adds support for the WBX daughterboard, when used
with the USRP2.

From 2f149cf2aa094e50bbcfea81d17d874a2f86588e Mon Sep 17 00:00:00 2001
From: Elvis D. [email protected]
Date: Mon, 9 May 2011 23:33:46 +0400
Subject: [PATCH] gnuradio-exampes/python/usrp2/usrp2_wfm_rcv: Add
support for WBX daughterboard.

Signed-off-by: Elvis D. [email protected]

gnuradio-examples/python/usrp2/usrp2_wfm_rcv.py | 3 +±
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/gnuradio-examples/python/usrp2/usrp2_wfm_rcv.py
b/gnuradio-examples/python/usrp2/usrp2_wfm_rcv.py
index 1783660…2b94c45 100755
— a/gnuradio-examples/python/usrp2/usrp2_wfm_rcv.py
+++ b/gnuradio-examples/python/usrp2/usrp2_wfm_rcv.py
@@ -87,7 +87,8 @@ class wfm_rx_block (stdgui2.std_top_block):
dbid == 0x0040 or #usrp_dbid.TV_RX_REV_3
dbid == 0x0043 or #usrp_dbid.TV_RX_MIMO
dbid == 0x0044 or #usrp_dbid.TV_RX_REV_2_MIMO

  •            dbid == 0x0045 ): #usrp_dbid.TV_RX_REV_3_MIMO

  •            dbid == 0x0045 or #usrp_dbid.TV_RX_REV_3_MIMO

  •            dbid == 0x0053 ): #usrp_dbid.WBX
       print "This daughterboard does not cover the required

frequency range"
print “for this application. Please use a BasicRX or TVRX
daughterboard.”
raw_input(“Press ENTER to continue anyway, or Ctrl-C to
exit.”)

1.7.0.4

Elvis D.

2

On May 9, 2011, at 11:41 PM, Elvis D. wrote:

I was quite surprised when I had commit access to the master branch. Isn’t that
a bit too open, or uncontrolled? :slight_smile: Not that I’m complaining, but mistakes can
happen, and the worst kind of mistake is if someone does a forced update from
their local branch to the git master branch, thereby over-writing all changes on
the master branch.

Sorry, about that, it was a false alarm.

I just realized that I commited my changes to my local branch
(gnuradio-3.4.0), and when I push my changes using git gui to the master
branch, it just updated my local master branch, not the one on the main
git server!

Elvis D.