Incorrect macro ngx_log_alloc_log

The macro in core/ngx_log.h is not correct:

#define ngx_log_alloc_log(pool, log) ngx_palloc(pool, log,
sizeof(ngx_log_t))

ngx_palloc only requires two arguments.

This function is never used, but I was trying to use it in mod_wsgi!

Manlio P.

On Mon, Mar 17, 2008 at 11:25:53PM +0100, Manlio P. wrote:

The macro in core/ngx_log.h is not correct:

#define ngx_log_alloc_log(pool, log) ngx_palloc(pool, log,
sizeof(ngx_log_t))

ngx_palloc only requires two arguments.

This function is never used, but I was trying to use it in mod_wsgi!

Please, do not use it, I will remove this ancient artifact.

Igor S. ha scritto:

This function is never used, but I was trying to use it in mod_wsgi!

Please, do not use it, I will remove this ancient artifact.

Ok, thanks.

By the way, I use it to make a copy of ngx_cycle->log, since I need to
modify the log->connection attribute.

Manlio P.

On Tue, Mar 18, 2008 at 08:27:48PM +0100, Manlio P. wrote:

This function is never used, but I was trying to use it in mod_wsgi!

Please, do not use it, I will remove this ancient artifact.

Ok, thanks.

I will also remove ngx_log_copy_log(), because it the same as:

*newlog = *oldlog;

On 03/19/08 13:58, Cherife Li wrote:

good at reworking
the Makefile.

Could Igor check this and fix it, please?
Or, is there any good suggestion?
Thanks in advance.

Besides, how can I control the installation dir of html files?
I didn’t got an option of ./configure for that.

The configuration for the HTML dir is controlled by the nginx.conf
file, which by default is located in /usr/local/nginx/conf/.

-Liang

Hi, all,

While building nginx package for Slackware linux, I found that I can’t
make the
‘install’ command to install things into the desired directory. That’s
to say,
make install DESTDIR
was of no effect.

I found this is controlled in the SRC/objs/Makefile file. But I’m not
good at reworking
the Makefile.

Could Igor check this and fix it, please?
Or, is there any good suggestion?
Thanks in advance.

On Wed, Mar 19, 2008 at 2:17 PM, kingler [email protected] wrote:

The configuration for the HTML dir is controlled by the nginx.conf
file, which by default is located in /usr/local/nginx/conf/.

-Liang

I mean while compiling nginx, which option like ./configure ***
–with-datadir=*** could
be used to control the installation dir of the html files under
srcdir/html/*. :slight_smile:
I found that they are installed in PREFIX/html dir by default through
Makefile.

Maybe my question is carking, pls forgive my estheticism. lol

why not use:
ln -s

2008/3/19, kingler [email protected]:

On 03/19/08 15:42, bianbian wrote:

why not use:
ln -s

Yeah, this is a choice.
But why don’t we just put things in the desired dir directly like many
other source
codes do.
BTW: IMHO, except necessary, it’s a bad method to arrange files link
here and there.

I see what you mean. Since there is no much option yet, you are
basically suggesting an addition of a new configure option for this.
Let’s see what Igor has to say on this.

-Liang