How was code reviewed before employing GitHub PR?

Hello,

I’m interested in understanding the code review process of Rails.
I find that GitHub PR was used by Rails since the end of 2009,
and I want to know, before that, how code review was conducted.
Through a code review mailing list? or any other code review systems?
Are there archives of those reviews?

Anyone knows? Thank you!

Shin

On Tuesday, May 26, 2015 at 11:46:59 AM UTC+1, [email protected]
wrote:

Hello,

I’m interested in understanding the code review process of Rails.
I find that GitHub PR was used by Rails since the end of 2009,
and I want to know, before that, how code review was conducted.
Through a code review mailing list? or any other code review systems?
Are there archives of those reviews?

You used to post your patches on the rails trac instance, and later the
lighthouse tracker. Looks like the trac instance no longer exists, but
the
lighthouse data is still at https://rails.lighthouseapp.com. Discussion
took place there & on the rails-core mailing list and the rails-contrib
IRC
channel.

Fred

I see.
Thank you very much! Fred.

Shin

2015-05-26 23:28 GMT+08:00 Frederick C.
[email protected]:

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs