The debugger method shouldn’t be in spec_helper.rb. It’s a IronRuby
specific method and that file is a MSpec file. Also, it’s missing an
Other than that, test looks good.
From: Shri B.
Sent: Thursday, April 02, 2009 12:08 PM
To: IronRuby External Code R.
Cc: [email protected]
Subject: FYI review - Jirapong’s fixes for GzipFile#finish
FYI review only…
This is Jirapong’s change. A big thanks to Jirapong for his first
contribution to IronRuby! Looking forward to many more!
I have pushed it to my fork. The individual commits are shown below, but
there will be a bit of noise as Jirapong bounced questions off me. I
should probably have squashed his individual commits into one to remove
the noise. Might do that for the next round…
GzipFile#finish should close the GzipReader/GzipWriter, but not the
underlying IO object.