FYI Review: Jirapong's fix for Kernel.open with permissions


#1

FYI only…

http://github.com/Jirapong/ironruby/commit/4fe87082c15101ab2af9432ef203517935e8d970
(Jirapong’s change)


(my code review)

GitDiff.bat 870c65e53faa912030475da393569a02bc308a2b
5e8c6b232a3c952985adbf1b9cda5c456d503cea

fix kernel.open with permission parameter

Files changed:

Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/kernel/open_tags.txthttp://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-0
*
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/open_spec.rbhttp://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-1
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cshttp://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-2
*
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cshttp://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-3
*
Merlin/Main/Languages/Ruby/Ruby/Runtime/Calls/ProtocolConversionAction.cshttp://github.com/shri/ironruby/commit/5e8c6b232a3c952985adbf1b9cda5c456d503cea#diff-4

Thanks,
Shri