tfpt review “/shelveset:config;REDMOND\sborde”
Comment :
Change RbConfig::CONFIG[“arch”] to “universal-dotnet2.0” (or
“universal-dotnet4.0” on .NET 4)
Also changed RbConfig::CONFIG[“host_os”] to be based on RUBY_PLATFORM
so that it will be mswin32 on Windows and linux on Linux.
Removed some config values that are not present in JRuby
Looks good. As part of MQ, we should look deeply at the compilation
based variables and see if they can be removed or picked up from the
arguments to csc.
JD
I still have misgivings about RUBY_PLATFORM identifying the underlying
OS,
when in reality, the platform that Ruby is running on is the CLR.
Based on this change, I will update my patch for Ruby Gems and resubmit
to
that team.
–
Will G.
http://hotgazpacho.org/
+1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out
rbconfig.rb?
What is MQ?
–
Will G.
http://hotgazpacho.org/
MQ stands for quality milestone. It’s a period teams often use to pay of
engineering debt. We will be doing some of that after IronRuby 1.0
ships.
From: [email protected]
[mailto:[email protected]] On Behalf Of Will G.
Sent: Thursday, March 11, 2010 7:11 PM
To: ironruby-core
Subject: Re: [Ironruby-core] FYI Code Review: config
+1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out
rbconfig.rb?
What is MQ?
–
Will G.
http://hotgazpacho.org/
On Thu, Mar 11, 2010 at 2:53 PM, Jim D.
<[email protected]mailto:[email protected]> wrote:
Looks good. As part of MQ, we should look deeply at the compilation
based variables and see if they can be removed or picked up from the
arguments to csc.
JD
Watch out for leaking Microsoft-speak 
Sorry about that.
JD
From: [email protected]
[mailto:[email protected]] On Behalf Of Shri B.
Sent: Friday, March 12, 2010 9:58 AM
To: [email protected]
Subject: Re: [Ironruby-core] FYI Code Review: config
MQ stands for quality milestone. It’s a period teams often use to pay of
engineering debt. We will be doing some of that after IronRuby 1.0
ships.
From: [email protected]
[mailto:[email protected]] On Behalf Of Will G.
Sent: Thursday, March 11, 2010 7:11 PM
To: ironruby-core
Subject: Re: [Ironruby-core] FYI Code Review: config
+1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out
rbconfig.rb?
What is MQ?
–
Will G.
http://hotgazpacho.org/
On Thu, Mar 11, 2010 at 2:53 PM, Jim D.
<[email protected]mailto:[email protected]> wrote:
Looks good. As part of MQ, we should look deeply at the compilation
based variables and see if they can be removed or picked up from the
arguments to csc.
JD