Fw: [ruby-gnome2-cvs] CVS: ruby-gnome2/gdkpixbuf rbgdk-pixbu

Hi Guillaume,

I reverted this change.

Please ask us before changing APIs.

This is Gdk::Pixbuf#scale!. So dest and src should be changed from C
GTK.

Begin forwarded message:

Date: Sat, 07 Jul 2007 07:46:11 -0700
From: Guillaume C. [email protected]
To: [email protected]
Subject: [ruby-gnome2-cvs] CVS: ruby-gnome2/gdkpixbuf rbgdk-pixbuf.c,
1.43, 1.44

Update of /cvsroot/ruby-gnome2/ruby-gnome2/gdkpixbuf
In directory sc8-pr-cvs9.sourceforge.net:/tmp/cvs-serv32561

Modified Files:
rbgdk-pixbuf.c
Log Message:
fix wrong order of arguments in using gdk_pixbuf_scale

Index: rbgdk-pixbuf.c

RCS file: /cvsroot/ruby-gnome2/ruby-gnome2/gdkpixbuf/rbgdk-pixbuf.c,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -d -r1.43 -r1.44
— rbgdk-pixbuf.c 7 Jul 2007 14:43:52 -0000 1.43
+++ rbgdk-pixbuf.c 7 Jul 2007 14:46:09 -0000 1.44
@@ -431,7 +431,7 @@
if (!NIL_P(interp_type))
type = RVAL2GENUM(interp_type, GDK_TYPE_INTERP_TYPE);

  • gdk_pixbuf_scale(_SELF(dest), _SELF(self),
  • gdk_pixbuf_scale(_SELF(self), _SELF(dest),
    NUM2INT(dest_x), NUM2INT(dest_y),
    NUM2INT(dest_width), NUM2INT(dest_height),
    NUM2DBL(offset_x), NUM2DBL(offset_y),

This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/


ruby-gnome2-cvs mailing list
[email protected]


.:% Masao M.[email protected]


This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Hi Masao,

I reverted this change.

Please ask us before changing APIs.

My intention was absolutely not to change th API. I would have asked
on this list, as I usually do. I was reviewing the code of the file,
and fixed a couple of things. I wrongly assumed you mixed the
arguments over in this call. I didn’t look deep enough, and I made
this mistake. Sorry!


Guillaume C. - Guillaume Cottenceau


This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/