Filename encodings for Ruby 1.9, more generic

Desktop Ruby-Gnome 2
1

Hi Kouhei & all,

So I have commited the filename encodings for Ruby 1.9 patch on
rbgtkfilechooser.c.

Now I think the moment is to make it more generic, because there are
similar filename-related operations elsewhere.
So I have moved the tool stuff from rbgtkfilechooser.c to glib2
submodule, and also implemented the use of the new generic way in a
first other file, rbglib_bookmarkfile.c.

Please tell me what you think, thanks!

2

Hi,

In [email protected]
“[ruby-gnome2-devel-en] filename encodings for Ruby 1.9, more generic”
on Mon, 4 Oct 2010 23:21:12 +0200,
Guillaume C. [email protected] wrote:

So I have commited the filename encodings for Ruby 1.9 patch on
rbgtkfilechooser.c.

Thanks!!!

Now I think the moment is to make it more generic, because there are
similar filename-related operations elsewhere.
So I have moved the tool stuff from rbgtkfilechooser.c to glib2
submodule, and also implemented the use of the new generic way in a
first other file, rbglib_bookmarkfile.c.

Please tell me what you think, thanks!

I agree with your suggestion. I want you to commit your patch.
(I’m sorry about I always care about small things but) Here
are some comments:

(1) Please use "gchar " style instead of "gchar " style.
(2) Please define RVAL2XXX and XXX2RVAL macros and use them.

Thanks for your contributions!

kou

3

Please tell me what you think, thanks!

I agree with your suggestion. I want you to commit your patch.
(I’m sorry about I always care about small things but) Here

No problem about small things, as long as they make sense and your
review is not taking a lot of days, it’s fine. I am glad if the code
quality and consistency is high in ruby-gnome2.

are some comments:

(1) Please use "gchar " style instead of "gchar " style.
(2) Please define RVAL2XXX and XXX2RVAL macros and use them.

Ok!

By the way, you haven’t replied to my other mail, mainly about the
change of HAVE_RB_STR_ENCODE to HAVE_RUBY_ENCODING_H in existing
places?

–
Guillaume C. - Guillaume Cottenceau

4

Hi,

In [email protected]
“Re: [ruby-gnome2-devel-en] filename encodings for Ruby 1.9, more
generic” on Tue, 5 Oct 2010 18:13:03 +0200,
Guillaume C. [email protected] wrote:

(1) Please use "gchar " style instead of "gchar " style.
(2) Please define RVAL2XXX and XXX2RVAL macros and use them.

can you review attached patch?

It seems good to me!
Please commit it!

Thanks,

kou

5

 (1) Please use "gchar " style instead of "gchar " style.
 (2) Please define RVAL2XXX and XXX2RVAL macros and use them.

can you review attached patch?