Devel policy (small issue)

I have noticed in pango/src/rbpangofont.c:

return c ? BOXED2RVAL(c, PANGO_TYPE_COVERAGE) : Qnil;

but the rbgobj_make_boxed triggered by BOXED2RVAL already returns Qnil
if the passed first argument is no true. Is it because it is older
code when rbgobj_make_boxed didn’t do so? If so, I can propose to use
a quick script[1] to “clean” all the occurrences of this.

[1] I’m afraid I would write it in Perl :confused:


Guillaume C. - http://zarb.org/~gc/

Hi,

On Sun, 18 Jun 2006 23:15:46 +0200
“Guillaume C.” [email protected] wrote:

I have noticed in pango/src/rbpangofont.c:

return c ? BOXED2RVAL(c, PANGO_TYPE_COVERAGE) : Qnil;

but the rbgobj_make_boxed triggered by BOXED2RVAL already returns Qnil
if the passed first argument is no true. Is it because it is older
code when rbgobj_make_boxed didn’t do so?

Yes. There are many codes like this.
e.g.) “a ? Qtrue : Qfalse” should change CBOOL2RVAL(a), too.

If so, I can propose to use
a quick script[1] to “clean” all the occurrences of this.

[1] I’m afraid I would write it in Perl :confused:

Perl ! Why!?

But OK. I think you have the account of developer CVS.
Could you fix them and apply it to CVS?
#If you need, I’ll check your patch before you’ll commit it to CVS.


.:% Masao M.[email protected]

[1] I’m afraid I would write it in Perl :confused:

Perl ! Why!?

Because I’m much more comfortable with Perl for one/two liners (and
IMHO Perl is more convenient because more lenient - vivification of
variables for example).

But OK. I think you have the account of developer CVS.
Could you fix them and apply it to CVS?

Yes, I can.

#If you need, I’ll check your patch before you’ll commit it to CVS.

I don’t need this but if you are more comfortable verifying first,
just let me know.


Guillaume C. - http://zarb.org/~gc/

Hi,

On Wed, 21 Jun 2006 08:37:15 +0200
“Guillaume C.” [email protected] wrote:

Yes, I can.

#If you need, I’ll check your patch before you’ll commit it to CVS.

I don’t need this but if you are more comfortable verifying first,
just let me know.

No problem. Apply it unless my verifying, please.


.:% Masao M.[email protected]

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs