Deprecating {{}} and welcoming %{}

josevalim · April 30, 2010, 6:58pm

Hey guys,

I did a couple benchmarks related with using {{}} or %{} as
interpolation option in message and got the following results.

Using Ruby 1.9.1

{{}} 525.48 ms
%{} 320.03 ms

Using REE

{{}} 813.61 ms
%{} 637.31 ms

This means a 40% improvement on using %{} over {{}} for Ruby 1.9.1 and
20% for REE. T

Therefore I want to propose deprecating the current syntax in favor of
%{}. But you may ask, why deprecate if both syntaxes works? The main
reason is that we can just obtain these good results if we remove the
gsub call:

github.com

ruby-i18n/i18n/blob/master/lib/i18n/backend/base.rb#L200


      
          #   # => "["yes, bartuz",["maybe no, bartuz", "no, bartuz"]]"
          def interpolate(locale, subject, values = EMPTY_HASH)
            return subject if values.empty?
          
          
  case subject
            when ::String then I18n.interpolate(subject, values)
            when ::Array then subject.map { |element| interpolate(locale, element, values) }
            else
              subject
            end
          end
          
          
# Deep interpolation
          #
          #   deep_interpolate { people: { ann: "Ann is %{ann}", john: "John is %{john}" } },
          #                    ann: 'good', john: 'big'
          #   #=> { people: { ann: "Ann is good", john: "John is big" } }
          def deep_interpolate(locale, data, values = EMPTY_HASH)
            return data if values.empty?
          
          
  case data

Otherwise the improvement falls to half. So, what are your thoughts?

josevalim · April 30, 2010, 6:59pm

Ah, I must add that using %{} removes the need to use the
interpolation compiler.

josevalim · April 30, 2010, 7:03pm

I think it’s a good idea. It improves performance and encourages
developers to use standard Ruby 1.9 syntax as opposed to custom
functionality specific to this library. As long as there’s a
sufficiently long deprecation period, I really see no drawbacks.

-Norman

josevalim · April 30, 2010, 7:20pm

Ah, the benchmark performed the following operation:

I18n.backend.translate :en, :“activerecord.errors.models.user.blank”,
:model
=> “User”, :attribute => “name”

With the following yml:

i18n/benchmark/example.yml at master · ruby-i18n/i18n · GitHub

josevalim · May 3, 2010, 8:00am

Hi JosÃ©

Regardless the performance improvement, I had suggested to deprecate the
{{}} months ago when %{} made it’s way into the rails code. I think it
makes more sense to stick to standard ruby syntax (which can be
optimized by the compiler) instead of sticking to a syntax that was
invented for rails only.

Cheers,
Lawrence