Comment requested on first Rails code

Hi,
I recently started playing with RoR, and I am not sure if I got my setup
right. Could someone comment on the code below?

Background: I want to expand/collapse a list of items. The expanded list
represents a recursive hierarchical tree, while the collapsed one shows
the
first tree level below the current position.

  1. My controller has:

def index

This action defines the content of a complete page, irrelevant code

has
been omitted)
end

def expand

irrelevant code omitted

render :partial => ‘children_recursive’
end

def collapse

irrelevant code omitted

render :partial => ‘children’
end

The relevant part of the index view looks like this:

<%= render :partial => 'children' %>

The children and children_recursive partial views contain two lines
each:

<%= link_to_remote(“Expand”, :update => ‘children’, :url => { :action =>
“expand”, :id => @page.id })%>
<%= display_children %>

<%= link_to_remote(“Collapse”, :update => ‘children’, :url => { :action
=>
“compress”, :id => params[:id] })%>
<%= display_children(@children, true) %>

The real work is done by a helper method (display_children), which
creates a
recursive HTML list if the second parameter evaluates to true:

def display_children([email protected], recursive=nil)

irrelevant code omitted

end

Coming from Perl, I know there’s more than one way to do it - but does
this
look like a reasonable way? I feel that there should be a simpler way
than
creating two actions, two partial views and a helper method for a simple
task like this.

Thanks for your comments,
Jan

#irrelevant suggestion omitted

Looks alright to me.

On Dec 24, 2007 8:43 AM, Jan E. [email protected] wrote:

def index

irrelevant code omitted

Jan


Ryan B.
http://www.frozenplague.net
Feel free to add me to MSN and/or GTalk as this email.

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs