Code Reviews

Ruby
1

As a solo Ruby programmer and one who is still on the learning curve, I
wanted
to get people’s thoughts about code reviews. I have a pretty complex
script that
I need to clean up some, but once I’ve done that, I would love to find a
place
where I could have a couple of people tear through it and say “Hey,
don’t do
that! Instead do this…”. This list is not that place, but I’m
wondering if
people have suggestions on where I should look.

Thanks,
Wayne

2

Post the code to http://chopapp.com/ and then post the link here. You
may be able to get some people to take a look and comment on it.

3

How is this different from a gist post?

4

It has a red button.

5

On Jan 17, 2013, at 9:27, Wayne B. [email protected] wrote:

As a solo Ruby programmer and one who is still on the learning curve, I wanted
to get people’s thoughts about code reviews. I have a pretty complex script that
I need to clean up some, but once I’ve done that, I would love to find a place
where I could have a couple of people tear through it and say “Hey, don’t do
that! Instead do this…”. This list is not that place, but I’m wondering if
people have suggestions on where I should look.

This list is TOTALLY that place. If you’d like more real time feedback,
join us on irc.

6

Hi Wayne,

I forgot to mention you should read the Ruby version of that book.

Regards,

Thiel

Op 17-1-2013 18:27, Wayne B. schreef:

7

Hi,

I should recommend to read (and study) the book “Refactoring” written
by Jay Fields, Shane Harvie and Martin F… It learns you how to
recognize bad smell Ruby code and helps to transform “chaotic” software
into well designed systems that are easieer to understand and to
maintanin.

Regards,

Thiel

Op 17-1-2013 18:27, Wayne B. schreef:

8

Pull request on github.com or bitbucket.org would be the perfect way of
how to do a code review. In my team it is the prefered way of how to let
other team members to see my work and the only way of how to merge it
into the codebase.

  1. create a new branch in git (the repo must be stored on github or
    bitbucket)
  2. write the code a push it to a remote branch
  3. create a pull request against your master branch
  4. ask for feedback here with the link of the pull request
  5. change the code based on the feedback
  6. merge it to master
  7. repeat :wink:

vlad