tfpt review “/shelveset:YamlRange;REDMOND\olegtk”
Comment :
Fixes Range support: implements taguri() and loading Range object from
yaml.
Changes constructors to hold a reference to a code context instead of
EqualityComparer (Range constructors wants it).
Why not to add Range constructor w/o CodeContext instead? The context is
used only to compare bounds. Does YAML actually invoke <=> method when
constructing range?
Tomas
Awesome catch!
Oleg
From: Tomas M.
Sent: Friday, June 27, 2008 6:31 PM
To: Oleg T.; IronRuby External Code R.
Cc: [email protected]
Subject: RE: Code Review: YamlRange
Why not to add Range constructor w/o CodeContext instead? The context is
used only to compare bounds. Does YAML actually invoke <=> method when
constructing range?
Tomas
Currently YAML just deserializes bound values (as objects) and passes
then to the Range constructor.
Do you mean that YAML can check bounds itself before constructing range?
–
Oleg
After F2F check with Tomas we figured out the CodeContext is still
needed here.
–
Oleg