Code Review: VisibilityAndOtherFixes2


#1

tfpt review “/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat”
Comment :
Implements
- private method visibility
- DATA constant
- popen and duplex IO streams (will need some refactoring of
RubyIO object)

  Fixes:
  - warnings (verbosity levels, Kernel#warn)
  - Kernel#gets, print, puts (no dynamic call to IO#puts)
  - method reflection: Kernel#methods, Kernel#singleton_methods 

(methods were missing in some cases)
- $~ variable scoping (should be an inner-most non-block scope)
- inclusion of module already included in a super class was
handled incorrectly

Tomas


#2

On Sun, Nov 16, 2008 at 4:10 PM, Tomas M. <
removed_email_address@domain.invalid> wrote:

tfpt review “/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat”
Comment :
Implements
- private method visibility

drools


#3

Changes look good.


#4

Test looks good.

JD

From: removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Michael
Letterle
Sent: Sunday, November 16, 2008 3:25 PM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: Re: [Ironruby-core] Code Review: VisibilityAndOtherFixes2

On Sun, Nov 16, 2008 at 4:10 PM, Tomas M.
<removed_email_address@domain.invalidmailto:removed_email_address@domain.invalid>
wrote:
tfpt review “/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat”
Comment :
Implements
- private method visibility

drools