As a slight variation/summarization, I’d suggest making a branch for any
specific change you’ll be making, especially if it’ll be made up of
multiple commits. Pulls could be made on master, and merged into the
branch as needed. Then, you could rebase and present the change as one
commit to your master branch, which then could go out for code review.
Though, I liked having many small changes, since the modified-file-count
was small per link, so it was almost like having a file list. Though
github makes it a bit irritating that it doesn’t show the diffs of new
or deleted files, so you have to click on each one of those.
[mailto:email@example.com] On Behalf Of Shri B.
Sent: Monday, March 30, 2009 4:44 PM
To: Jim D.
Subject: [Ironruby-core] Mapping multiple pushes to a single review
Could you have avoided doing pulls from the main repo? Not ideal but
given the tools we have, we will have to figure out a solution that
balances all interests.
You could have a separate branch for active work if you do need pulls
for main for some other reason like doing code reviews for others, just
keeping on top of whats going on, etc.
Also, if you can manage to avoid pulls from the main repo, should
rebasing be recommended? You want to do frequent pushes maily to back up
your changes in the cloud, and so rebasing sounds like a good option
once you are finally happy with the changes and want to push it into
your master branch. It will be easier to browse file histories…
Also, I suppose this issue is not unique to IronRuby. How do other
projects deal with code reviews, keeping file history less noisy, etc?
From: Jim D.
Sent: Friday, March 27, 2009 11:40 AM
To: IronRuby External Code R.
Subject: Code Review: Various .NET interop tests
This is one of the weak areas for our Git setup. I have multiple commits
that need review. I honestly feel that Git needs the concept of a push
object, so I could say look at this, or these pushes. So, options to
help you review:
git://github.com/jredville/ironruby.git, and setup Git Extensions, you
should be able to click on each commit, and each file at your leisure)
commits and files from IronRuby’s main repo’s pushes)
We’re trying to figure something better out, including possibly using
Review Board (http://review-board.org). So, now for the actual review:
This a some work on Generic Method specs, as well as more general work
on a first pass of the test plan
#line pragmas instead of
ir.exe instead of
(base class) type