Code Review: unni1

tfpt review “/shelveset:unni1;REDMOND\jdeville”
Comment :
Patch from Unnikrishnan N. to properly handle File.zero? for ‘NUL’

Reviewed F2F with John

JD

While testing this manually I discovered that CRuby treats nul and NUL
as zero length files, while this patch only works for NUL. Unni, can you
fix that and resubmit?

Thanks,

JD

yes, I will do that.
Thanks.
Unni

— On Tue, 7/15/08, Jim D. [email protected] wrote:

From: Jim D. [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1
To: “[email protected][email protected],
“IronRuby External Code R.” [email protected]
Date: Tuesday, July 15, 2008, 3:51 PM

While testing this manually I discovered that CRuby treats nul and NUL
as zero
length files, while this patch only works for NUL. Unni, can you fix
that and
resubmit?

Thanks,

JD

Jim,
Â
As per your comments, I have modified the code and ran against Matz Ruby
and verified the results. Yes you are correct ‘nul’ is same as ‘NUL’ as
well. I have updated the patch as well.
Â
Just curious, how come there is no representation of IronRuby in
Lonestar Ruby conference?
Â
Thanks.
Unni

— On Wed, 7/16/08, Unnikrishnan N. [email protected] wrote:

From: Unnikrishnan N. [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1
To: [email protected]
Date: Wednesday, July 16, 2008, 10:34 AM

yes, I will do that.
Thanks.
Unni

— On Tue, 7/15/08, Jim D. [email protected] wrote:

From: Jim D. [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1
To: “[email protected][email protected],
“IronRuby External Code R.” [email protected]
Date: Tuesday, July 15, 2008, 3:51 PM

While testing this manually I discovered that CRuby treats nul and NUL
as zero
length files, while this patch only works for NUL. Unni, can you fix
that and
resubmit?

Thanks,

JD

Cool, I’ll get that integrated into the repo. I don’t know why we didn’t
send someone to Lonestar. Probably just a case of limited resources.

JD

From: [email protected]
[mailto:[email protected]] On Behalf Of Unnikrishnan
Nair
Sent: Wednesday, July 16, 2008 7:52 PM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1

Jim,

As per your comments, I have modified the code and ran against Matz Ruby
and verified the results. Yes you are correct ‘nul’ is same as ‘NUL’ as
well. I have updated the patch as well.

Just curious, how come there is no representation of IronRuby in
Lonestar Ruby conference?

Thanks.

Unni

— On Wed, 7/16/08, Unnikrishnan N. [email protected] wrote:
From: Unnikrishnan N. [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1
To: [email protected]
Date: Wednesday, July 16, 2008, 10:34 AM

yes, I will do that.

Thanks.

Unni

— On Tue, 7/15/08, Jim D. [email protected] wrote:
From: Jim D. [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1
To: “[email protected][email protected],
“IronRuby External Code R.” [email protected]
Date: Tuesday, July 15, 2008, 3:51 PM

While testing this manually I discovered that CRuby treats nul and NUL
as zero

length files, while this patch only works for NUL. Unni, can you fix
that and

resubmit?

Thanks,

JD

-----Original Message-----

From: [email protected] [mailto:ironruby-core-

[email protected]] On Behalf Of Jim D.

Sent: Tuesday, July 15, 2008 2:31 PM

To: [email protected]; IronRuby External Code R.

Subject: Re: [Ironruby-core] Code Review: unni1

Reviewed F2F with John

JD

-----Original Message-----

From: [email protected] [mailto:ironruby-core-

[email protected]] On Behalf Of Jim D.

Sent: Tuesday, July 15, 2008 1:45 PM

To: IronRuby External Code R.

Cc: [email protected]

Subject: [Ironruby-core] Code Review: unni1

tfpt review “/shelveset:unni1;REDMOND\jdeville”

Comment :

Patch from Unnikrishnan N. to properly handle File.zero? for

‘NUL’


Ironruby-core mailing list

[email protected]

http://rubyforge.org/mailman/listinfo/ironruby-core


Ironruby-core mailing list

[email protected]

http://rubyforge.org/mailman/listinfo/ironruby-core


Ironruby-core mailing list

[email protected]

http://rubyforge.org/mailman/listinfo/ironruby-core

As much as we would love to attend more Ruby conferences (and there are
a LOT of Ruby conferences!), we really don’t have the bandwidth. So
we’re being very careful about where we go.

We’ll be at RubyConf this year.

Thanks,
-John

From: [email protected]
[mailto:[email protected]] On Behalf Of Unnikrishnan
Nair
Sent: Wednesday, July 16, 2008 10:52 PM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1

Jim,

As per your comments, I have modified the code and ran against Matz Ruby
and verified the results. Yes you are correct ‘nul’ is same as ‘NUL’ as
well. I have updated the patch as well.

Just curious, how come there is no representation of IronRuby in
Lonestar Ruby conference?

Thanks.

Unni

— On Wed, 7/16/08, Unnikrishnan N. [email protected] wrote:
From: Unnikrishnan N. [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1
To: [email protected]
Date: Wednesday, July 16, 2008, 10:34 AM

yes, I will do that.

Thanks.

Unni

— On Tue, 7/15/08, Jim D. [email protected] wrote:
From: Jim D. [email protected]
Subject: Re: [Ironruby-core] Code Review: unni1
To: “[email protected][email protected],
“IronRuby External Code R.” [email protected]
Date: Tuesday, July 15, 2008, 3:51 PM

While testing this manually I discovered that CRuby treats nul and NUL
as zero

length files, while this patch only works for NUL. Unni, can you fix
that and

resubmit?

Thanks,

JD

-----Original Message-----

From: [email protected] [mailto:ironruby-core-

[email protected]] On Behalf Of Jim D.

Sent: Tuesday, July 15, 2008 2:31 PM

To: [email protected]; IronRuby External Code R.

Subject: Re: [Ironruby-core] Code Review: unni1

Reviewed F2F with John

JD

-----Original Message-----

From: [email protected] [mailto:ironruby-core-

[email protected]] On Behalf Of Jim D.

Sent: Tuesday, July 15, 2008 1:45 PM

To: IronRuby External Code R.

Cc: [email protected]

Subject: [Ironruby-core] Code Review: unni1

tfpt review “/shelveset:unni1;REDMOND\jdeville”

Comment :

Patch from Unnikrishnan N. to properly handle File.zero? for

‘NUL’


Ironruby-core mailing list

[email protected]

http://rubyforge.org/mailman/listinfo/ironruby-core


Ironruby-core mailing list

[email protected]

http://rubyforge.org/mailman/listinfo/ironruby-core


Ironruby-core mailing list

[email protected]

http://rubyforge.org/mailman/listinfo/ironruby-core

I was really looking forward to meet you guys here at Texas, well next
time. Matz is giving the key note.
Thanks.
Unni

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs